Properly handle bulk tracking #4135

Closed
halfdan opened this Issue Sep 6, 2013 · 2 comments

3 participants

@halfdan
Piwik Open Source Analytics member

There are some flaws in the current way bulk tracking is handled:

Code:

Sent to security@.

Documentation:
The documentation only shows only one way to format the JSON data (http://piwik.org/docs/tracking-api/reference/#toc-advanced-bulk-tracking-requests). It is much cleaner to send the request strings as array (although there might be a little overhead).

E.g. this is a completely valid request:

{
   "requests": [
      { idsite: 1, url: "http://example.org", action_name: "Test bulk log Pageview", rec: 1 },
      { idsite: 1, url: "http://example.net/test.htm", action_name: "Another bulk page view", rec:1 }
   ],
   "token_auth": "33dc3f2536d3025974cccb4b4d2d98f4"
}
@anonymous-piwik-user

In 8c1fcc1: Fix authentication for bulk tracking

refs #4135

@mattab
Piwik Open Source Analytics member

In 15dcd00: Fixes #4135 kuddos @halfdan for finding the bug & patch!

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab was assigned by halfdan Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Fix authentication for bulk tracking
refs #4135
8c1fcc1
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Fixes #4135 kuddos @halfdan for finding the bug & patch! 15dcd00
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment