Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bulk import API #4141

Closed
halfdan opened this Issue · 6 comments

2 participants

@halfdan
Collaborator

The bulk import API is relatively hard to use right now:

  • When successful the transparent GIF is returned instead of a status message in JSON
  • When an error occurs because of an invalid token_auth a plain text message is returned (exitWithException isn't used in this case).
  • exitWithException doesn't set application/json header nor an appropriate status code
  • admin_token_auth is never set in UsersManager on loadWebsiteAttributes which makes it impossible for admin users to use bulk import
@anonymous-piwik-user

In 1a6b565: Properly set admin_token_auth attribute for website attributes

refs #4141

@anonymous-piwik-user

In f985d16: Properly catch exception on failed authentication for bulk import
Set correct header for application/json

refs #4141

@anonymous-piwik-user

In 67c2973: Return JSON string on error in bulk tracking
Return JSON string with statistics on success

fixes #4141

@anonymous-piwik-user

In 1ca9d90: Fix test for now changed bulk tracking response (valid JSON)

refs #4141

@anonymous-piwik-user

In ccd81be: Fix stalling tests in ArchiveCronTest

refs #4141

@anonymous-piwik-user

In 6765b82: Fix bulk tracking expected responses

refs #4141

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone
@halfdan halfdan self-assigned this
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Properly catch exception on failed authentication for bulk import
Set correct header for application/json

refs #4141
f985d16
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Return JSON string on error in bulk tracking
Return JSON string with statistics on success

fixes #4141
67c2973
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Fix stalling tests in ArchiveCronTest
refs #4141
ccd81be
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Fix bulk tracking expected responses
refs #4141
6765b82
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.