Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Plugins define translations they need as a hook: Remove _js hack! #4151

Closed
diosmosis opened this Issue · 13 comments

4 participants

@diosmosis
Collaborator

Use an event that plugins can use to determine which translations should be available in JavaScript and load them all automatically.

@anonymous-piwik-user

In a5ab907: Refs #4151, remove loadJavascriptTranslations twig function and automatically generate translation JS for all plugins. Translation JS is now treated as an asset and is included in merged JS.

Note:

  • Includes tweaks to capture.js: on webpage error stop capture program.
@anonymous-piwik-user

In 3a2c5f4: Refs #4151, refactor translation JavaScript generation code and add event so plugins can specify which strings should be available client-side.

@anonymous-piwik-user

In 807336d: Refs #4151, make sure translations JS is always regenerated when merged assets is disabled.

@anonymous-piwik-user

In e88b30a: Refs #4151, make sure developing w/ merged assets disabled isn't a big pain.

@anonymous-piwik-user

In 330bde5: Refs #4151, fix regression caused by refactoring hack.

@sgiehl
Collaborator

In e0fd925: refs #4151 refactored some usages of _js hack

@sgiehl
Collaborator

In 7589d30: refs #4151 refactored some more usages of _js hack

@sgiehl
Collaborator

In 55cbbec: refs #4151 refactored some more usages of _js hack

@sgiehl
Collaborator

In 2fa88c2: refs #4151 refacoted some more usages of _js hack

@sgiehl
Collaborator

In 4cdb957: refs #4151 refactored more _js hack uses

@sgiehl
Collaborator

In aa6bef2: refs #4151 refactored last usages of _js hack

@sgiehl
Collaborator

In fd18ea2: fixes #4151 removed _js hack

@mattab
Owner

Beautiful change guys...

@diosmosis diosmosis added this to the 2.0 - Piwik 2.0 milestone
@sgiehl sgiehl was assigned by diosmosis
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@diosmosis diosmosis Refs #4151, remove loadJavascriptTranslations twig function and autom…
…atically generate translation JS for all plugins. Translation JS is now treated as an asset and is included in merged JS.

Note:
  - Includes tweaks to capture.js: on webpage error stop capture program.
a5ab907
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@diosmosis diosmosis Refs #4151, refactor translation JavaScript generation code and add e…
…vent so plugins can specify which strings should be available client-side.
3a2c5f4
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@diosmosis diosmosis Refs #4151, make sure translations JS is always regenerated when merg…
…ed assets is disabled.
807336d
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4151 refactored some usages of _js hack e0fd925
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4151 refactored some more usages of _js hack 7589d30
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4151 refactored some more usages of _js hack 55cbbec
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4151 refacoted some more usages of _js hack 2fa88c2
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4151 refactored more _js hack uses 4cdb957
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4151 refactored last usages of _js hack aa6bef2
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl fixes #4151 removed _js hack fd18ea2
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.