Plugins define translations they need as a hook: Remove _js hack! #4151

Closed
diosmosis opened this Issue Sep 12, 2013 · 13 comments

4 participants

@diosmosis
Piwik Open Source Analytics member

Use an event that plugins can use to determine which translations should be available in JavaScript and load them all automatically.

@anonymous-piwik-user

In a5ab907: Refs #4151, remove loadJavascriptTranslations twig function and automatically generate translation JS for all plugins. Translation JS is now treated as an asset and is included in merged JS.

Note:

  • Includes tweaks to capture.js: on webpage error stop capture program.
@anonymous-piwik-user

In 3a2c5f4: Refs #4151, refactor translation JavaScript generation code and add event so plugins can specify which strings should be available client-side.

@anonymous-piwik-user

In 807336d: Refs #4151, make sure translations JS is always regenerated when merged assets is disabled.

@anonymous-piwik-user

In e88b30a: Refs #4151, make sure developing w/ merged assets disabled isn't a big pain.

@anonymous-piwik-user

In 330bde5: Refs #4151, fix regression caused by refactoring hack.

@sgiehl
Piwik Open Source Analytics member

In e0fd925: refs #4151 refactored some usages of _js hack

@sgiehl
Piwik Open Source Analytics member

In 7589d30: refs #4151 refactored some more usages of _js hack

@sgiehl
Piwik Open Source Analytics member

In 55cbbec: refs #4151 refactored some more usages of _js hack

@sgiehl
Piwik Open Source Analytics member

In 2fa88c2: refs #4151 refacoted some more usages of _js hack

@sgiehl
Piwik Open Source Analytics member

In 4cdb957: refs #4151 refactored more _js hack uses

@sgiehl
Piwik Open Source Analytics member

In aa6bef2: refs #4151 refactored last usages of _js hack

@sgiehl
Piwik Open Source Analytics member

In fd18ea2: fixes #4151 removed _js hack

@mattab
Piwik Open Source Analytics member

Beautiful change guys...

@diosmosis diosmosis added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@sgiehl sgiehl was assigned by diosmosis Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4151, remove loadJavascriptTranslations twig function and autom…
…atically generate translation JS for all plugins. Translation JS is now treated as an asset and is included in merged JS.

Note:
  - Includes tweaks to capture.js: on webpage error stop capture program.
a5ab907
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4151, refactor translation JavaScript generation code and add e…
…vent so plugins can specify which strings should be available client-side.
3a2c5f4
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4151, make sure translations JS is always regenerated when merg…
…ed assets is disabled.
807336d
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4151, make sure developing w/ merged assets disabled isn't a bi…
…g pain.
e88b30a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4151, fix regression caused by refactoring hack. 330bde5
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4151 refactored some usages of _js hack e0fd925
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4151 refactored some more usages of _js hack 7589d30
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4151 refactored some more usages of _js hack 55cbbec
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4151 refacoted some more usages of _js hack 2fa88c2
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4151 refactored more _js hack uses 4cdb957
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4151 refactored last usages of _js hack aa6bef2
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl fixes #4151 removed _js hack fd18ea2
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment