Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove file functions.php and only use static helpers #4202

Closed
mattab opened this Issue · 10 comments

1 participant

Matthieu Aubry
Matthieu Aubry
Owner

The file core/functions.php is a left over from the old days of not using namespaces. Let's remove these functions and instead, directly call the helpers.

Matthieu Aubry
Owner

In 4d34198: Refs #4202 removing functions Piwik_PostEvent and moving to Piwik::postEvent

Matthieu Aubry
Owner

In 6d46df5: Refs #4202 removing functions Piwik_GetOption and SetOption. Now use: Option::get and Option::set and Option::delete

Matthieu Aubry
Owner

In 81ccb29: Refs #4202 removing functions Piwik_Translate and Piwik_TranslateException

Matthieu Aubry
Owner

In 9c3a523: Refs #4202 fix build

Matthieu Aubry
Owner

In e9817e9: Refs #4202 Menu refactor GO. This one is tricky...

Matthieu Aubry
Owner

In 500373c: Refs #4202 Menu refactor GO. This one is tricky...

Matthieu Aubry
Owner

In 6cb020e: Refs #4202 Menu refactor done

Matthieu Aubry
Owner

In efa8f7a: Refs #4202 submodule trickery

Matthieu Aubry
Owner

NICE!

Matthieu Aubry
Owner

In 82695ac: Refs #4202 Cleaning up the good old bridge classes

Matthieu Aubry mattab added this to the 2.0 - Piwik 2.0 milestone
Matthieu Aubry mattab self-assigned this
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 removing functions Piwik_GetOption and SetOption. Now use:…
… Option::get and Option::set and Option::delete
6d46df5
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 fix build 9c3a523
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 Menu refactor GO. This one is tricky... e9817e9
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 Menu refactor GO. This one is tricky... 500373c
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 Menu refactor done 6cb020e
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 submodule trickery efa8f7a
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4202 Cleaning up the good old bridge classes 82695ac
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.