Remove file functions.php and only use static helpers #4202

Closed
mattab opened this Issue Oct 7, 2013 · 10 comments

1 participant

@mattab
Piwik Open Source Analytics member

The file core/functions.php is a left over from the old days of not using namespaces. Let's remove these functions and instead, directly call the helpers.

@mattab
Piwik Open Source Analytics member

In 4d34198: Refs #4202 removing functions Piwik_PostEvent and moving to Piwik::postEvent

@mattab
Piwik Open Source Analytics member

In 6d46df5: Refs #4202 removing functions Piwik_GetOption and SetOption. Now use: Option::get and Option::set and Option::delete

@mattab
Piwik Open Source Analytics member

In 81ccb29: Refs #4202 removing functions Piwik_Translate and Piwik_TranslateException

@mattab
Piwik Open Source Analytics member

In 9c3a523: Refs #4202 fix build

@mattab
Piwik Open Source Analytics member

In e9817e9: Refs #4202 Menu refactor GO. This one is tricky...

@mattab
Piwik Open Source Analytics member

In 500373c: Refs #4202 Menu refactor GO. This one is tricky...

@mattab
Piwik Open Source Analytics member

In 6cb020e: Refs #4202 Menu refactor done

@mattab
Piwik Open Source Analytics member

In efa8f7a: Refs #4202 submodule trickery

@mattab
Piwik Open Source Analytics member

NICE!

@mattab
Piwik Open Source Analytics member

In 82695ac: Refs #4202 Cleaning up the good old bridge classes

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 removing functions Piwik_PostEvent and moving to Piwik::po…
…stEvent
4d34198
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 removing functions Piwik_GetOption and SetOption. Now use:…
… Option::get and Option::set and Option::delete
6d46df5
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 removing functions Piwik_Translate and Piwik_TranslateExce…
…ption
81ccb29
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 fix build 9c3a523
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 Menu refactor GO. This one is tricky... e9817e9
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 Menu refactor GO. This one is tricky... 500373c
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 Menu refactor done 6cb020e
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 submodule trickery efa8f7a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4202 Cleaning up the good old bridge classes 82695ac
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment