Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

geoip DB automatic update doesn't respect update period #4263

Closed
hpvd opened this Issue · 29 comments

4 participants

hpvd null-minus-null Matthieu Aubry Benaka
hpvd

geoip DB automatic update doesn't respect update period
please see attachement

seen in piwik 2.0 pre beta 3 (from github master)

hpvd

update period selection was untouched for several months (updating from Piwik 1.12...)

hpvd

no update yet, please see new attachment...

Matthieu Aubry
Owner

Thanks for the report!

@diosmosis do you have any idea about this bug?

hpvd

add screenshot with the setting...

hpvd

updated this morning to piwik 2.0b5

last update date is still the same 10.10.2013

=> the update was also not perfomed simply within the wrong period (e.g. every month, instead of the selected "every week")
=> the update process still seem not to work in general

Benaka
Collaborator

In 250a832: Fixes #4263, make sure GeoIPAutoUpdater forces new scheduled time of update task to be persisted when update period is set.

hpvd

now piwik 2.0 RC2 is installed - no update yet. Last one was 10/10/2013
Updated to nearly every new beta in the meantime...
Please see attachment.

hpvd

maybe a button "update now" + good error messages would be helpful to find the problem...

Benaka
Collaborator

Changing the period doesn't immediately start the update. Did you change from monthly to weekly? In that case the next update should be this week (on the 20th based on the last time it was run). Otherwise it will be next month.

Admittedly, this isn't the best solution. Having an 'update now' link would be good, but due to the way MaxMind hosts their databases, it's not easy to do this through the browser.

In the meantime, I think rescheduling to the next cron run (if the database is out of date) and having a message that displays the next scheduled run time would be a good idea.

hpvd

changed in both directions several times during the last month piwik/betas..

Shouldn't it update /respect the periods even without any changes??

yes your idea to show the next scheduled update date is great!
=> new Ticket?
and the "update now button" another one for a future milestone?

hpvd

updated to piwik 2.02 => still no update.
Last update was still 10-10-2013

null-minus-null

Attachment:
FTP.PNG

null-minus-null

I found something even more strange in my Piwik installation.
It seems that not only the update does not work as expected(see PIWIK.PNG), but that also the given date (here march 2013) is wrong, because the file actually was changed in august 2013(see FTP.PNG).

PS I'm sure the file has not been modified by anything else than Piwik.

Benaka
Collaborator

In 6a60bcd: Refs #4263, fix bugs in geoip auto updater, show next scheduled time for updater in admin screen and refactor the updater a bit.

Benaka
Collaborator

In d1b6596: Refs #4263, display next scheduled run time for geoip updater task, make sure updater is run in next cron run if a file is out of date, & forgot to commit new file in last commit.

Benaka
Collaborator

In 77ea9ff: Fixes #4263, fix bug in weekly scheduled time period and fix bugs in last commit.

hpvd

many thanks for pointing to the plugin.

After install (in piwik 2.04b1) it shows something really weird:

  • there are two tasks regarding geoip update
  • both are on different dates and
  • both are in the past (2013)

Piwik_UserCountry_GeoIPAutoUpdater.update October 16, 2013 00:00 (in 271 Tage -8756 Stunden)
GeoIPAutoUpdater.update December 18, 2013 00:00 (in 334 Tage -8756 Stunden)

please see attachment

In addition the last update from geoip updater shows still 10-10-2013 (today is January 17th 2014 and setting is weekly update)

please see other attachment

hpvd

maybe this is depend from this:
#4612
?

Matthieu Aubry
Owner

Removing owner from tickets. from now on, I suggest we assign tickets to ourselves for cases when we we plan to actively work on them in the coming days/weeks. let's discuss if needed during our team call.

hpvd

finally fixed by fixing:
#4612

see also:
#4652

now everything works fine!

Matthieu Aubry
Owner

In a27a417: Fixes #4263 geoip automatic updates are working for me with latest git, even in webcron. please reopen if: the next update is scheduled in the future properly, but the updater is not running.

hpvd hpvd added this to the 2.1 - Piwik 2.1 milestone
Matthieu Aubry mattab was assigned by hpvd
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Benaka diosmosis Fixes #4263, make sure GeoIPAutoUpdater forces new scheduled time of …
…update task to be persisted when update period is set.
250a832
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Benaka diosmosis Refs #4263, fix bugs in geoip auto updater, show next scheduled time …
…for updater in admin screen and refactor the updater a bit.
6a60bcd
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Benaka diosmosis Refs #4263, display next scheduled run time for geoip updater task, m…
…ake sure updater is run in next cron run if a file is out of date, & forgot to commit new file in last commit.
d1b6596
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Benaka diosmosis Fixes #4263, fix bug in weekly scheduled time period and fix bugs in …
…last commit.
77ea9ff
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Fixes #4263 geoip automatic updates are working for me with latest gi…
…t, even in webcron. please reopen if: the next update is scheduled in the future properly, but the updater is not running.
a27a417
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.