geoip DB automatic update doesn't respect update period
please see attachement
seen in piwik 2.0 pre beta 3 (from github master)
update period selection was untouched for several months (updating from Piwik 1.12...)
no update yet, please see new attachment...
Thanks for the report!
@diosmosis do you have any idea about this bug?
add screenshot with the setting...
updated this morning to piwik 2.0b5
last update date is still the same 10.10.2013
=> the update was also not perfomed simply within the wrong period (e.g. every month, instead of the selected "every week")
=> the update process still seem not to work in general
In 250a832: Fixes #4263, make sure GeoIPAutoUpdater forces new scheduled time of update task to be persisted when update period is set.
now piwik 2.0 RC2 is installed - no update yet. Last one was 10/10/2013
Updated to nearly every new beta in the meantime...
Please see attachment.
maybe a button "update now" + good error messages would be helpful to find the problem...
Changing the period doesn't immediately start the update. Did you change from monthly to weekly? In that case the next update should be this week (on the 20th based on the last time it was run). Otherwise it will be next month.
Admittedly, this isn't the best solution. Having an 'update now' link would be good, but due to the way MaxMind hosts their databases, it's not easy to do this through the browser.
In the meantime, I think rescheduling to the next cron run (if the database is out of date) and having a message that displays the next scheduled run time would be a good idea.
changed in both directions several times during the last month piwik/betas..
Shouldn't it update /respect the periods even without any changes??
yes your idea to show the next scheduled update date is great!
=> new Ticket?
and the "update now button" another one for a future milestone?
updated to piwik 2.02 => still no update.
Last update was still 10-10-2013
I found something even more strange in my Piwik installation.
It seems that not only the update does not work as expected(see PIWIK.PNG), but that also the given date (here march 2013) is wrong, because the file actually was changed in august 2013(see FTP.PNG).
PS I'm sure the file has not been modified by anything else than Piwik.
In 6a60bcd: Refs #4263, fix bugs in geoip auto updater, show next scheduled time for updater in admin screen and refactor the updater a bit.
In d1b6596: Refs #4263, display next scheduled run time for geoip updater task, make sure updater is run in next cron run if a file is out of date, & forgot to commit new file in last commit.
In 77ea9ff: Fixes #4263, fix bug in weekly scheduled time period and fix bugs in last commit.
Test this plugin which gives the next run time for scheduled task.
many thanks for pointing to the plugin.
After install (in piwik 2.04b1) it shows something really weird:
Piwik_UserCountry_GeoIPAutoUpdater.update October 16, 2013 00:00 (in 271 Tage -8756 Stunden)
GeoIPAutoUpdater.update December 18, 2013 00:00 (in 334 Tage -8756 Stunden)
please see attachment
In addition the last update from geoip updater shows still 10-10-2013 (today is January 17th 2014 and setting is weekly update)
please see other attachment
maybe this is depend from this:
Removing owner from tickets. from now on, I suggest we assign tickets to ourselves for cases when we we plan to actively work on them in the coming days/weeks. let's discuss if needed during our team call.
finally fixed by fixing:
now everything works fine!
In a27a417: Fixes #4263 geoip automatic updates are working for me with latest git, even in webcron. please reopen if: the next update is scheduled in the future properly, but the updater is not running.
Fixes #4263, make sure GeoIPAutoUpdater forces new scheduled time of …
…update task to be persisted when update period is set.
Refs #4263, fix bugs in geoip auto updater, show next scheduled time …
…for updater in admin screen and refactor the updater a bit.
Refs #4263, display next scheduled run time for geoip updater task, m…
…ake sure updater is run in next cron run if a file is out of date, & forgot to commit new file in last commit.
Fixes #4263, fix bug in weekly scheduled time period and fix bugs in …
Fixes #4263 geoip automatic updates are working for me with latest gi…
…t, even in webcron. please reopen if: the next update is scheduled in the future properly, but the updater is not running.