Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update TCPDF to latest version #4288

Closed
mattab opened this Issue · 3 comments

1 participant

@mattab
Owner

User reported bug in: http://forum.piwik.org/read.php?8,107402

Notice: Undefined variable: filehash in /var/www/vhosts/foxwebcreations.net/subdomains/tracking/httpdocs/libs/tcpdf/tcpdf.php on line 7421

I verified and it looks like the bug has been fixed in latest TCPDF. So let's upgrade the lib to latest.

PS: I noticed it's using composer so we could plug it our composer file...

@mattab
Owner

In b42e9f8: Refs #4288 Upgrading TCPDF but the tests then fail. It seems the generated PDF has some random content (after copying from Processed/ -> expected/ the test still fails)

@mattab
Owner

In 420d454: Fixes #4288 Remove from the PDF the metadata that changes with datetime, or that is random.This ensures that when we compare two binary PDF files together, the comparison does not take into account these random bits in the pdf files.

@mattab
Owner

In 750e544: Refs #4288 removes useless files

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone
@mattab mattab self-assigned this
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4288 Upgrading TCPDF but the tests then fail. It seems the gene…
…rated PDF has some random content (after copying from Processed/ -> expected/ the test still fails)
b42e9f8
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Fixes #4288 Remove from the PDF the metadata that changes with dateti…
…me, or that is random.This ensures that when we compare two binary PDF files together, the comparison does not take into account these random bits in the pdf files.
420d454
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4288 removes useless files 750e544
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.