Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Morpheus theme shouldn't force aspect ratio on custom branding logo #4408

Closed
nkuehn opened this Issue · 4 comments

3 participants

Nikolaus Kühn Matthieu Aubry Anonymous Piwik user
Nikolaus Kühn

(found in 2.0.1)

The Morpheus theme currently sets a fixed height and width to the logo in the main interface:

#logo img {
    height: 21px;
    margin-top: 14px;
    width: 82px;
}

That overwrites the default (Zeitgeist?) that just sets 40px height.

I think: As not all Logos (e.g. branding) are made equal concerning their height the CSS shouldn't impose an aspect ratio by setting width and height to a fixed size (the size of the piwik logo). The same accounts for the absoulte height: not all logos work visually in 20px height. The Morpheus theme has space for max 50px high logos, but that looks to dense. The 40px default does in fact make sense.

My suggestion (logically, not directly CSS):

  • set a max-height instead of a fixed height (prevents smaller logos from being blown up to uglyness)
  • preserve aspect ratio (like Zeitgeist does)
  • center the logo vertically (not via setting a fixed "margin-top" that works only for the piwik logo).

Implementation of the vertical centering is a mess although. Vertical centering is one of the uglier areas of CSS (see http://www.vanseodesign.com/css/vertical-centering/ for all of its "beauty").

I just played around with using the (much more powerful and elegant) CSS background-* possibilities. They're nice, but finally not ideal because the width is unknown and the clickable area shouldn't be bigger or smaller than the logo.

A possible quick-fix could be to agree on a bigger fixed logo height (e.g. 34px like the current piwik raw logo file is), remove the width CSS and crack the the vertical-centering nut later.

PS: Same applies to the login screen, would be nice if the logo appears bigger there.

Keywords: theme, branding

Matthieu Aubry
Owner

Thanks for the report

Anonymous Piwik user

The suggestions in the bug report sound good to me. Another issue I found was that this setting in the
config/piwik.ini.php
file:

[branding]
use_custom_logo = 1

doesn't appear to be respected in Piwik 2.x.

Matthieu Aubry
Owner

In 5fce035: Adding class to core logo so that only core piwik logo is impacted by morpheus tweaks Fixes #4408
Thanks for the report!

Nikolaus Kühn

Wow, that was quick.

Thanks a lot!

Nikolaus Kühn nkuehn added this to the 2.0.3 - Piwik 2.0.3 milestone
Matthieu Aubry mattab was assigned by nkuehn
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Adding class to core logo so that only core piwik logo is impacted by…
… morpheus tweaks Fixes #4408

Thanks for the report!
5fce035
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.