Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove DoNotTrack and Anonymize plugins and move them to PrivacyManager #4493

Closed
mattab opened this Issue · 7 comments

3 participants

Matthieu Aubry Benaka Stefan Giehl
Matthieu Aubry
Owner

The DoNotTrack plugin is a small plugin. Enabling / disabling DoNotTrack is done by enabling/disabling the plugin. I would prefer if DNT was a setting in the config file, and so enabling/disabling would not require plugin enable/disable.

Benaka
Collaborator

In fb5454b: Fixes #4493, move DoNotTrack & AnonymizeIP logic to PrivacyManager plugin. Includes modification to EventDipatcher to allow generic callbacks in getListHooksRegistered method.

Stefan Giehl
Collaborator

In 755013d: refs #4493 renamed translation key

Matthieu Aubry
Owner

feedback:

  • I think we must make sure they are never laoded (events executed) or displayed in the manage plugins page (in case we can't write the config on upgrade). Otherwise we could have the new DNT and the old running at the same time.... Maybe we blacklist these two plugins?
  • an error reported in the forums http://forum.piwik.org/read.php?2,109744 Call to undefined method Piwik\Plugins\PrivacyManager\Controller::isDntSupported()
Matthieu Aubry
Owner

In 14dbfac: Refs #4493 Function was renamed

Matthieu Aubry
Owner

In a665821: Fix jsProxyTest, ie. make tracker work refs #4493
Why include file manually? because piwik.php does not use autoloader yet.
Maybe as part of refs #4074 we could setup autoloader for piwik.php / tracking API.

Matthieu Aubry
Owner

In bb65f51: Fixes #4493 Make sure tracker cache also contain the Anonymizer IP settings + debug output

Matthieu Aubry
Owner

In 8a6d8c4: Refs #4493 Typo

Matthieu Aubry mattab added this to the 2.0.3 - Piwik 2.0.3 milestone
Benaka diosmosis was assigned by mattab
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Benaka diosmosis Fixes #4493, move DoNotTrack & AnonymizeIP logic to PrivacyManager pl…
…ugin. Includes modification to EventDipatcher to allow generic callbacks in getListHooksRegistered method.
fb5454b
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Stefan Giehl sgiehl refs #4493 renamed translation key 755013d
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4493 Function was renamed 14dbfac
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Fix jsProxyTest, ie. make tracker work refs #4493
Why include file manually? because piwik.php does not use autoloader yet.
Maybe as part of refs #4074 we could setup autoloader for piwik.php / tracking API.
a665821
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Fixes #4493 Make sure tracker cache also contain the Anonymizer IP se…
…ttings + debug output
bb65f51
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4493 Typo 8a6d8c4
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.