Remove DoNotTrack and Anonymize plugins and move them to PrivacyManager #4493

Closed
mattab opened this Issue Jan 9, 2014 · 7 comments

3 participants

@mattab
Piwik Open Source Analytics member

The DoNotTrack plugin is a small plugin. Enabling / disabling DoNotTrack is done by enabling/disabling the plugin. I would prefer if DNT was a setting in the config file, and so enabling/disabling would not require plugin enable/disable.

@diosmosis
Piwik Open Source Analytics member

In fb5454b: Fixes #4493, move DoNotTrack & AnonymizeIP logic to PrivacyManager plugin. Includes modification to EventDipatcher to allow generic callbacks in getListHooksRegistered method.

@sgiehl
Piwik Open Source Analytics member

In 755013d: refs #4493 renamed translation key

@mattab
Piwik Open Source Analytics member

feedback:

  • I think we must make sure they are never laoded (events executed) or displayed in the manage plugins page (in case we can't write the config on upgrade). Otherwise we could have the new DNT and the old running at the same time.... Maybe we blacklist these two plugins?
  • an error reported in the forums http://forum.piwik.org/read.php?2,109744 Call to undefined method Piwik\Plugins\PrivacyManager\Controller::isDntSupported()
@mattab
Piwik Open Source Analytics member

In 14dbfac: Refs #4493 Function was renamed

@mattab
Piwik Open Source Analytics member

In a665821: Fix jsProxyTest, ie. make tracker work refs #4493
Why include file manually? because piwik.php does not use autoloader yet.
Maybe as part of refs #4074 we could setup autoloader for piwik.php / tracking API.

@mattab
Piwik Open Source Analytics member

In bb65f51: Fixes #4493 Make sure tracker cache also contain the Anonymizer IP settings + debug output

@mattab
Piwik Open Source Analytics member

In 8a6d8c4: Refs #4493 Typo

@mattab mattab added this to the 2.0.3 - Piwik 2.0.3 milestone Jul 8, 2014
@diosmosis diosmosis was assigned by mattab Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@diosmosis diosmosis Fixes #4493, move DoNotTrack & AnonymizeIP logic to PrivacyManager pl…
…ugin. Includes modification to EventDipatcher to allow generic callbacks in getListHooksRegistered method.
fb5454b
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl sgiehl refs #4493 renamed translation key 755013d
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4493 Function was renamed 14dbfac
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Fix jsProxyTest, ie. make tracker work refs #4493
Why include file manually? because piwik.php does not use autoloader yet.
Maybe as part of refs #4074 we could setup autoloader for piwik.php / tracking API.
a665821
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Fixes #4493 Make sure tracker cache also contain the Anonymizer IP se…
…ttings + debug output
bb65f51
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4493 Typo 8a6d8c4
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment