Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

When adding new annotation calendar not visible .... #4510

Closed
anonymous-piwik-user opened this Issue · 15 comments

4 participants

Anonymous Piwik user Matthieu Aubry Stefan Giehl Thomas Steur
Anonymous Piwik user

When you add new annotation calendar is not visible. It has "wrong Z index". Hard to add new annotation.

Anonymous Piwik user

Issue observed with FF 26.0 and IE 11.02 (maybe with other browsers also).

Matthieu Aubry
Owner

btw this was fixed once in #4386 then reverted in 872781a#commitcomment-5136079

Anonymous Piwik user

In ab210e9: Fix hidden date selector for annotations.

fixes #4510

Matthieu Aubry
Owner

See attached file, some widgets can overflow, so maybe we find another fix

Matthieu Aubry
Owner

In 7f6509c: Refs #4510 Revert as it's causing visual bugs (some widget content now overflowing)

Anonymous Piwik user

In c65b1d5: Second attempt at fixing #4510. Only hide overflow-x.

refs #4510

Matthieu Aubry
Owner

Fyi on this screenshot: http://builds-artifacts.piwik.org/ui-tests.master/1421.1/processed-ui-screenshots/UIIntegrationTest_dashboard1.png

I now see a vertical scrollbar, maybe it can be hidden?

Matthieu Aubry
Owner

In 85a9e2d: Refs #4510 reverting change, I'll make UI tests build green first

Matthieu Aubry
Owner

The UI build should be green now! still unsure how to fix this bug without adding the scroll bars...

Matthieu Aubry
Owner

Removing owner from tickets. from now on, I suggest we assign tickets to ourselves for cases when we we plan to actively work on them in the coming days/weeks. let's discuss if needed during our team call.

Stefan Giehl
Collaborator

Setting div.dataTable's position not to absolute fixes this issue. But I'm not sure if it has other sideeffects.

https://github.com/piwik/piwik/blob/master/plugins/CoreHome/stylesheets/dataTable/_dataTable.less#L26 (removing that line fixes the issue)

Thomas Steur
Owner

In c04cdb5: fixes #4510 When adding new annotation calendar was not fully visible is dashboard

Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Fabian Becker halfdan Fix hidden date selector for annotations.
fixes #4510
ab210e9
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #4510 Revert as it's causing visual bugs (some widget content no…
…w overflowing)
7f6509c
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Fabian Becker halfdan Second attempt at fixing #4510. Only hide overflow-x.
refs #4510
c65b1d5
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur fixes #4510 When adding new annotation calendar was not fully visible…
… is dashboard
c04cdb5
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.