Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Automatically activate/deactivate the 'Login' plugin when activating another Login plugin (eg. LdapLogin) #4529

Closed
mattab opened this Issue · 2 comments

2 participants

@mattab
Owner

LdapLogin developer has found a bug: disabling the Login plugin within the LdapLogin activate() method, will not disable the Login plugin.

Let's fix it since it will solve the nice use case: when LdapLogin is enabled, the default Login plugin is disabled. When it Ldap is disabled, back to using default Login plugin... nice!

@mattab
Owner

In 4f9faf4: Refactor Manager around enable/disable of plugins: Fixes #4529 Login plugin can be enabled/disabled ie. when disabling/enabling LoginLdap
was reported in http://forum.piwik.org/read.php?9,109016

@anonymous-piwik-user

Thank you! Tested and confirmed as fixed.

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone
@mattab mattab self-assigned this
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refactor Manager around enable/disable of plugins: Fixes #4529 Login …
…plugin can be enabled/disabled ie. when disabling/enabling LoginLdap

was reported in http://forum.piwik.org/read.php?9,109016
4f9faf4
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.