Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

UI bugs connected to subdatatables #4536

Closed
BeezyT opened this Issue · 20 comments

2 participants

@BeezyT
Collaborator

Here's how to reproduce some bugs (tested in Safari and Chrome).

Go to http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=1&period=week&date=2014-01-10#module=Referrers&action=getSearchEnginesAndKeywords&idSite=1&period=week&date=2014-01-10

Bug 1:

  • In Search Engines, click Google - looks OK
  • Now, click Yahoo. The background of the subtable is grey - it should be white. On hover, the background is yellow - this color should not be used anymore.

(Now, refresh)

Bug 2:

  • Open Google in Search Engines
  • Hover the number of visits of Bing - the percentages are shown correctly
  • Now, hover the label of Bing - the percentages in the Google subtable are shown

(Now, refresh)

Bug 3:

  • Open any Search Engine
  • Hover any row below it. The background is too dark and as a consequence, the background of the row evolution icon is visible. This does not happen for the rows above the opened one.
@mattab
Owner

Thanks for the report!

@BeezyT
Collaborator

In 88aaf3f: refs #4536 improved striping for action data tables: when subtables are opened or closed, reset the odd/even labels. otherwise, two subsequent odd or even rows are possible.

@BeezyT
Collaborator

In 73a1b46: refs #4536: morpheus uses odd/even css classes instead of nth-child. this way, striping works properly on nested data tables (e.g. the search engines report). also, make the css overrides more effective (e.g. add :hover).

@BeezyT
Collaborator

In 5ad9080: refs #4536 fixing indentation of previous commits

@BeezyT
Collaborator

Bugs 1 and 3 from the ticket description should be gone now. Please let me know when the demo is updated so that I can test the exact steps mentioned in the description.

@BeezyT
Collaborator

In baeda26: refs #4536: only show the ratio in the current table - not in a subtable. fixes bug 2 from the ticket description.

@BeezyT
Collaborator

I think this ticket should be done now. As I said, I'd like to test it on the demo before closing it.

Please guys, test as much as you can. It is really hard to get this right. Open and close subtables (both tables like the pages report and tables like the search engines report) randomly and see whether you can spot another error.

@mattab
Owner

Nice changes!

Timo we now have the demo running latest git master at http://demo2.piwik.org
you can login there with the same username pwd as on demo.

@BeezyT
Collaborator

demo2 doesn't have the same data so I can't test the exact steps described above. I could reproduce the issues with data from my local environment and the problems are gone there. So I guess the bugs mentioned above are fixed now.

I'd still like to try it on the regular demo but that's not urgent. When do you think it will be updated the next time?

@mattab
Owner

In next couple days will be updated with the RC we are preparing.

Btw I noticed a regression:

  • in the admin table, such as Users, Websites, or Users permissions, the rows are now displayed in Grey rather than white background.
@BeezyT
Collaborator

In 6148bb1: refs #4536 admin tables are white in morpheus

@BeezyT
Collaborator

Is .entityTable the right selector to use? Please review the CSS change and test again.

@BeezyT
Collaborator

I can confirm that all three bugs from the description are now gone on the demo.

@BeezyT
Collaborator

In db95706: refs #4536: highlighting active plugins in the settings

@BeezyT
Collaborator

A commit above broke the screenshot UI tests.

I have also asked this on [[6148bb1#commitcomment-5330187%7Cgithub]]: Who determines what is expected and how can the expected screenshots be changed?

documentation] doesn't help much. Is there more documentation on the subject?

@mattab
Owner

In 7df0035: Explains how to fix UI tests build refs #4536

@BeezyT
Collaborator

In 011ed63: refs #4536 Updating expected UI screenshots in submodule

@BeezyT
Collaborator

I have updated these screenshots: [[https://raw.github.com/piwik/piwik-ui-tests/master/expected-ui-screenshots/UIIntegrationTest_customalerts_list_triggered.png|alerts history], [[https://raw.github.com/piwik/piwik-ui-tests/master/expected-ui-screenshots/UIIntegrationTest_customalerts_list.png|alerts]].

The [[http://builds-artifacts.piwik.org/ui-tests.master/1622.1/screenshot-diffs/diffviewer.html|diff]] contains more but they are not related to this ticket. I guess the UI tests will still fail.

Regarding the new [[https://github.com/piwik/piwik/blob/master/tests/README.screenshots.md#using-screenshots-tests|documentation]]: Thanks for adding this. The second bullet point (Click on the latest failed build) confused me a little. What is the latest failed build? I clicked on the "build failing" icon in the readme. Is that correct? Maybe the documentation could be clearer.

@BeezyT
Collaborator

I'll go ahead and close the ticket.

As I said, the UI was changed slightly. If there are objections to the changes (see screenshots above), reopen the ticket.

@mattab
Owner

In 41d2e8f: Refs #4536 Active Plugins in white, inactive plugin in grey.
Great work Timo on the other changes, it looks clean & smooth... beautiful!

@BeezyT BeezyT added this to the 2.1 - Piwik 2.1 milestone
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@BeezyT BeezyT refs #4536 improved striping for action data tables: when subtables a…
…re opened or closed, reset the odd/even labels. otherwise, two subsequent odd or even rows are possible.
88aaf3f
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@BeezyT BeezyT refs #4536: morpheus uses odd/even css classes instead of nth-child. …
…this way, striping works properly on nested data tables (e.g. the search engines report). also, make the css overrides more effective (e.g. add :hover).
73a1b46
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@BeezyT BeezyT refs #4536 fixing indentation of previous commits 5ad9080
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@BeezyT BeezyT refs #4536: only show the ratio in the current table - not in a subta…
…ble. fixes bug 2 from the ticket description.
baeda26
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@BeezyT BeezyT refs #4536 admin tables are white in morpheus 6148bb1
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Explains how to fix UI tests build refs #4536 7df0035
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@BeezyT BeezyT refs #4536 Updating expected UI screenshots in submodule 011ed63
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4536 Active Plugins in white, inactive plugin in grey.
Great work Timo on the other changes, it looks clean & smooth... beautiful!
41d2e8f
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.