tasks timetable plugin: take year into account #4540

Closed
hpvd opened this Issue Jan 17, 2014 · 6 comments

2 participants

@hpvd

Take year into account by calculation of time to task...

Otherwise these things could happen:

  • tasks from last year were shown
  • time calculation results are wrong

please see attachment

screenshot was taken on January 17th, 2014

@tsteur
Piwik Open Source Analytics member

In 8945245: refs #4540 fix time ago is not correct calculated if numberOfSeconds is negative

@tsteur
Piwik Open Source Analytics member

Time calculation is fixed.

I think it is intended to show previous tasks as it basically means they were not executed since then (but maybe should) and it helps you to discover this. Maybe I am wrong @matt? Please reopen if we should not show tasks from past

@hpvd

just updated to TasksTimetable v0.1.2 but it seems to be not completely fixed:

example (please see also attachment):

Scheduled Tasks
The following tasks are scheduled to be executed based on the current server time Friday 24 January 2014 09:04:13.

GeoIPAutoUpdater.update Wednesday 18 December 2013 00:00:46

(in 327 days -8746 hours)

=> time is still calculated wrong
=> maybe one should ad another text and position for "in" in front if the last run was in the past: e.g.: "ago" at the end

example:
(IN XXX days -YYYYY hours)
=>
(XXX days -yyyyyy hours AGO)

@tsteur
Piwik Open Source Analytics member

It is fixed in Piwik core, not in the plugin itself. Meaning you will see the fix with the next Piwik release.

@hpvd hpvd added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@tsteur tsteur was assigned by hpvd Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur tsteur refs #4540 fix time ago is not correct calculated if numberOfSeconds …
…is negative
8945245
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment