Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

CacheBuster is suboptimal #4567

Closed
halfdan opened this Issue · 3 comments

3 participants

@halfdan
Collaborator

The cache buster is generating a hash from several changing properties:

$pluginList = md5(implode(",", !$pluginNames ? Manager::getInstance()->getLoadedPluginsName() : $pluginNames));
$cacheBuster = md5(SettingsPiwik::getSalt() . $pluginList . PHP_VERSION . Version::VERSION . trim($currentGitHash));

Things to note:

  • md5 is used twice
  • SettingsPiwik::getSalt() is a static value.
@anonymous-piwik-user

In 74e9976: Simplify cache buster and use only values that can change.

fixes #4567

@robocoder

With git, I suppose devs commit more frequently. But just for historical context, I included the salt because I would frequently erase my config and re-install from my workspace without committing anything to svn.

@halfdan
Collaborator

Makes sense - but changing the salt wouldn't have any effect on the assets/cache.

@halfdan halfdan added this to the 2.1 - Piwik 2.1 milestone
@halfdan halfdan self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.