Show author of plugin #4578

Closed
halfdan opened this Issue Jan 26, 2014 · 9 comments

4 participants

@halfdan
Piwik Open Source Analytics member

The plugin listing (Platform > Plugins) currently uses undocumented keys from plugin.json to show the author and links to the author's homepage.

Authors can be added in plugin.json with an "authors" array (e.g. https://github.com/piwik/plugin-SecurityInfo/blob/master/plugin.json). However the plugin listing uses "author" and "author_homepage".

I think it is reasonable to simply show all the authors in a row (e.g. By Foo, Bar, Baz) with link to their homepage.

@mattab
Piwik Open Source Analytics member

Thanks for the report!

Indeed author_homepage is found many times in the source code, but not documented at: http://developer.piwik.org/guides/distributing-your-plugin

@tsteur, what are your thoughts on this one?

@halfdan
Piwik Open Source Analytics member

IMHO author and author_homepage should be removed in favor of the new "authors" array.

FYI, I've set myself as owner since I have the fix ready :P

@tsteur
Piwik Open Source Analytics member

+1 for removing author_homepage

@anonymous-piwik-user

In 4fcd238: Show list of plugin authors with homepage and use actual data from plugin.json

refs #4578

@anonymous-piwik-user

In cae15a3: Convert the old author/author_homepage to the new structure.

refs #4578

@halfdan
Piwik Open Source Analytics member

So - I converted all the old occurences in Piwik to the new data structure. This got me thinking: Do we need to show "By Piwik" on every core plugin? It's kinda obvious that the core plugins (with a few exceptions) are from Piwik.

@matt / @tsteur: Opinion?

@mattab
Piwik Open Source Analytics member

Nice one!

feedback:

  • I still see author_homepage and a couple occurences of 'author' in the code (via global search)
  • it's worth leaving 'By Piwik' otherwise it wouldn't be obvious; the only other indication is (core) but it's written in grey and people don't know what it means
@anonymous-piwik-user

In 3f6381b: Remove remaining occurences of author_home
Show Piwik for all core plugins

fixes #4578

@halfdan
Piwik Open Source Analytics member

Done and good catch! :)

@halfdan halfdan added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@halfdan halfdan self-assigned this Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Show list of plugin authors with homepage and use actual data from pl…
…ugin.json

refs #4578
4fcd238
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Convert the old author/author_homepage to the new structure.
refs #4578
cae15a3
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Remove remaining occurences of author_home
Show Piwik for all core plugins

fixes #4578
3f6381b
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment