Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove comments still referencing old Piwik_ (before using PHP 5.3 namespaces) #4609

Closed
mattab opened this Issue · 6 comments

3 participants

Matthieu Aubry Anonymous Piwik user Fabian Becker
Matthieu Aubry
Owner

I did a global search in the codebase and found hundreds of cases of Piwik_XYZ written in the codebase, mostly in comments, such as Piwik_Auth, Piwik_Db, Piwik_API, etc.

We should remove these references and replace with correct phpdoc blocks (or simply remove).

This would conclude our effort of migrating the whole codebase from pre-namespace to full namespace support (see also: #4074 )

Anonymous Piwik user

In b1ae26d: Removing occurences of Piwik_ in core/

  • @subpackage is deprecated
  • @package must only occur once
  • @package supports nesting (and can match the namespace)

refs #4609

Fabian Becker
Collaborator

It's worth reading up on http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/package.html

Both @category and @subpackage are deprecated. @package should only be used if it does not match the namespace. Also @package must not appear more than once in a file.

I suggest the following:

  • for core/ we remove @package
  • for plugins/ we use @package with the name of the plugin (and not the namespace - so Actions instead of Piwik\Plugins\Actions)

Feedback?

Anonymous Piwik user

In f9d52ca: Remove all occurences of @package / @subpackage / @category from core/ files.

refs #4609

Anonymous Piwik user

In 6b9ae92: Remove remaining @package/@subpackage/@category declarations from plugins/

fixes #4609

Anonymous Piwik user

In dde7c37: Removing last Piwik_ occurences

refs #4609

Matthieu Aubry
Owner

In 217b22b: Fixes #4609 Removing last mentions of Piwik_ -- Looking sharp now!

Matthieu Aubry mattab added this to the 2.1 - Piwik 2.1 milestone
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Fabian Becker halfdan Removing occurences of Piwik_ in core/
  * @subpackage is deprecated
  * @package must only occur once
  * @package supports nesting (and can match the namespace)

refs #4609
b1ae26d
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Fabian Becker halfdan Remove all occurences of @package / @subpackage / @category from core…
…/ files.

refs #4609
f9d52ca
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Fabian Becker halfdan Removing last Piwik_ occurences
refs #4609
dde7c37
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.