Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

username should be enclosed in double quotes in config files, in case the user name contains a = #481

Closed
mattab opened this Issue · 2 comments

2 participants

@mattab
Owner

From bug report: http://forum.piwik.org/index.php?showtopic=70

In the config file we should have ``` username = “my=username” ``` instead of ``` username = my=username ```

the same way the password is currently enclosed in double quotes

@robocoder

from #570, host should also be enclosed in quotes.

@mattab
Owner

fixed in 949

—> all non-array values in Config/config.ini.php are now automatically enclosed in double quotes, and double quote automatically encoded as " (parse_ini_file doesn’t handle escaping the double quote, arg)

cleaning the Piwik_Config code, adding tests, the code using the Config is now more simple, all the logic is inside the class (before it was very hacky). the installer is now using the Config to create the config file rather than duplicating the logic.
@mattab mattab added this to the RobotRock milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.