Skip to content

Loading…

Configurable access level for Segment Editor #5172

Closed
d-skora opened this Issue · 8 comments

2 participants

@d-skora

Currently, any non-anonymous logged-in user, can add new segment.

Expected: as a Piwik admin I want to set that only users with "view" or "admin" or "superuser" permission can create new segments.

@mattab
Piwik Open Source Analytics member

Thanks for the suggestion! See pull request: #275

@mattab
Piwik Open Source Analytics member

In 22227f6: Merge pull request #275 from d-skora/feature/SegmentEditor

Feature/segment editor Fixes #5172

@mattab
Piwik Open Source Analytics member

I realised the ticket description was not clear, and so the code IMHO is not correct.

I will commit some fix.

@mattab
Piwik Open Source Analytics member

In bdc6dbb: Refs #5172 Make sure anonymous user cannot edit segments + rename superadmin to superuser for consistency

@mattab
Piwik Open Source Analytics member

In f1c47b8: Refs #5172 Rename siteid to idSite for consistency

@mattab
Piwik Open Source Analytics member

In a1577f2: Refs #5172 Fix bug, use proper idSite value

@mattab
Piwik Open Source Analytics member

In 8885f29: Refs #5172 Rename config setting with a clear name, adding_segment_requires_access
idSite===false is not valid use case AFAIK so removing code that deals with that.

@mattab
Piwik Open Source Analytics member

In 75871ca: Fixes #5172 Should be code complete

@d-skora d-skora added this to the 2.3.0 - Piwik 2.3.0 milestone
@mattab mattab was assigned by d-skora
@fhemberger fhemberger pushed a commit that referenced this issue
@mattab mattab Refs #5172 Make sure anonymous user cannot edit segments + rename sup…
…eradmin to superuser for consistency
bdc6dbb
@fhemberger fhemberger pushed a commit that referenced this issue
@mattab mattab Refs #5172 Rename config setting with a clear name, adding_segment_re…
…quires_access

idSite===false is not valid use case AFAIK so removing code that deals with that.
8885f29
@fhemberger fhemberger pushed a commit that referenced this issue
@mattab mattab Fixes #5172 Should be code complete 75871ca
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.