Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Configurable access level for Segment Editor #5172

Closed
d-skora opened this Issue · 8 comments

2 participants

Daniel Skóra Matthieu Aubry
Daniel Skóra

Currently, any non-anonymous logged-in user, can add new segment.

Expected: as a Piwik admin I want to set that only users with "view" or "admin" or "superuser" permission can create new segments.

Matthieu Aubry
Owner

Thanks for the suggestion! See pull request: #275

Matthieu Aubry
Owner

In 22227f6: Merge pull request #275 from d-skora/feature/SegmentEditor

Feature/segment editor Fixes #5172

Matthieu Aubry
Owner

I realised the ticket description was not clear, and so the code IMHO is not correct.

I will commit some fix.

Matthieu Aubry
Owner

In bdc6dbb: Refs #5172 Make sure anonymous user cannot edit segments + rename superadmin to superuser for consistency

Matthieu Aubry
Owner

In f1c47b8: Refs #5172 Rename siteid to idSite for consistency

Matthieu Aubry
Owner

In a1577f2: Refs #5172 Fix bug, use proper idSite value

Matthieu Aubry
Owner

In 8885f29: Refs #5172 Rename config setting with a clear name, adding_segment_requires_access
idSite===false is not valid use case AFAIK so removing code that deals with that.

Matthieu Aubry
Owner

In 75871ca: Fixes #5172 Should be code complete

Daniel Skóra d-skora added this to the 2.3.0 - Piwik 2.3.0 milestone
Matthieu Aubry mattab was assigned by d-skora
Frederic Hemberger fhemberger referenced this issue from a commit
Matthieu Aubry mattab Refs #5172 Make sure anonymous user cannot edit segments + rename sup…
…eradmin to superuser for consistency
bdc6dbb
Frederic Hemberger fhemberger referenced this issue from a commit
Matthieu Aubry mattab Refs #5172 Rename config setting with a clear name, adding_segment_re…
…quires_access

idSite===false is not valid use case AFAIK so removing code that deals with that.
8885f29
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.