Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Report actions by html page title as well as reporting by URL (or custom page name) #530

Closed
mattab opened this Issue · 4 comments

2 participants

@mattab
Owner

Currently Piwik reports on pages URL structures, or if user specifies a custom action name in the javascript, Piwik reports on this custom name. Piwik has always access to the html page title and could build the report of the best page by title.

Therefore there would be a new API function to get the top pages by title, as well as the current method getActions to get the top actions by URL.

The title could be customized on the JS side by calling``` piwik.setDocumentTitle()```.

We would not report on best landing page, or top exit pages by title. We would not report on time per page title. These extra analysis would only be done on the URLs to minimize overhead during archiving.

@robocoder
Collaborator

piwik.js sends the document.title in the ‘title’ parameter but it is not currently used by the server. (A mod_security issue was raised in #564. We could add title_var_name to global.ini.php, in a similar manner to download_url_var_name, or we could use encodeURIComponent() in piwik.js instead of simply, escape().)

@robocoder
Collaborator

Re: previous comment. Upon closer inspection, the parameter name doesn’t matter. mod_security’s PHP injection rules are generic and extremely broad, e.g., ``` SecRule REQUEST_FILENAME|ARGS|ARGS_NAMES ``` i.e., try to match against the request filename, arguments, and argument names. To address the issue requires encoding all args from client-to-server, and a review of the arg names used in Piwik to make sure they aren’t on the blacklist.

Note: encodeURIComponent() doesn’t have a native PHP equivalent; similarly, there’s no native version of urlencode() for JavaScript.

@robocoder
Collaborator

Per analysis in #564, mod_security requirements are removed from this ticket.

@mattab
Owner

fixed in [1530]

@mattab mattab added this to the Piwik 0.5 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.