Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

API responses sub tables should contain same metrics as parent tables (filters should be applied recursively) #5593

Closed
mattab opened this Issue · 1 comment

1 participant

Matthieu Aubry
Matthieu Aubry
Owner

For example we do: ``` $dataTable = $this→getDataTable(‘Actions_outlink’, $idSite, $period, $date, $expanded, $idSubtable ); $dataTable→queueFilter(‘Piwik_DataTable_Filter_ColumnCallbackAddDetail’, array(‘label’, ‘url’, create_function(‘$url’, ‘return $url;’)));

```

But we may want to apply the filter recursively if the returned data table has many levels (the case for actions when searching recursively for example).

I can see 2 implementations:

*```

queueRecursiveFilter( Filter )```

*```

dataTable→setFiltersRecursive() ```

both are not incompatible. The first is better in my opinion.

Matthieu Aubry
Owner

(In [3764]) Fixes #5593 - making all filters recursive by default (no performance impact since it won't load the tables if they were not loaded in the API). Updating all filters to reflect new abstract class signature

Matthieu Aubry mattab added this to the Piwik 1.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.