Skip to content

Loading…

UI: Provide a site selector that would scale to thousands of websites (inline search, auto suggest, ajax) #5708

Closed
zawadzinski opened this Issue · 25 comments

4 participants

@zawadzinski

Create interactive site chooser.

See attachment.

How should it work?

1. when you click on dropdown menu it shows list of sites from piwik installation and and one special item (the first one) called “Search…” 1. when you click “Search…” we transform dropdown menu (select) into input text box 1. in input box we got “x” icon to switch back to dropdown menu (it is already implemented in data tables interface when you want to cancel your search, see screenshot) 1. when you type it displays results and highlight search keyword in javascript popup below, like in compose message in gmail (see screenshot) 1. you can either choose site or cancel search by clicking “x” icon
@zawadzinski

Attachment: already implemented interface in data table visualization [close search.png](http://issues.piwik.org/attachments/5708/close_search.png)

@zawadzinski

Attachment: gmail interactive dropdown [search results.png](http://issues.piwik.org/attachments/5708/search_results.png)

@zawadzinski

Attachment: project of site choose UI [search ui.png](http://issues.piwik.org/attachments/5708/search_ui.png)

@zawadzinski

see search UI.png attachment for detailed use case

@mattab
Piwik Open Source Analytics member

Attachment: google reader did exactly the same dropdown already! it works great. we should the same :-) [google-reader-selector.jpg](http://issues.piwik.org/attachments/5708/google-reader-selector.jpg)

@zawadzinski

attached an autocompleter after some minor patches, IE compatible now.

@mattab
Piwik Open Source Analytics member

Cool new feature - here is my code review

  • the query to select a website on name matching should reside in the website API rather than CoreController
  • pressing enter without selecting a website leads to 404, instead it should trigger the search for the entered keyword
  • is the initial load loading all websites? I don't think it is expected, what would happen if the piwik has 10000 websites? Instead, could it load only the first N websites?
  • when no result is found, the Loading... should be replaced with "No website found for '$SEARCHED_STRING'"
  • on firefox, the arrow on the right is on top the vertical bar on its left, which looks a bit funny
  • the font looks different from the font used elsewhere in the UI, should reuse the same CSS class?

When this is bug free, we can integrate this with core, nice new feature.

@zawadzinski

New version (v3), bug fixed, improvements made.

@robocoder

From a maintenance perspective, I'm a little concerned that the jSuggest developer's site has been marked as unsafe. There's also jSuggest "Enhanced", http://www.rajavarma.com/wp-content/uploads/2009/07/jquery.jSuggest.1.1.js which we should diff against for bug fixes.

Alternatively, see if https://jqueryui.pbworks.com/Autocomplete (in the development stage) can be used instead of jSuggest.

@mattab
Piwik Open Source Analytics member

Maciej, what is the status of the site selector? Is this something you are happy pushing to Piwik core? Please validate and I will do the code review.

@anonymous-piwik-user

This is to inform you that jQuery UI 1.8 has hit stable release and autocomplete is included, i dont know if we should switch to using it.

@robocoder

vnese: see #1235

@mattab
Piwik Open Source Analytics member

it would be great to switch to jquery UI, is anyone keen to make the code change (shouldn't be difficult I don't think)?

@mattab
Piwik Open Source Analytics member

Note: the HTML is now done in trunk, the JS + PHP has to be ported in trunk, from the plugin attached to this ticket.

@anonymous-piwik-user

Could this be added / implemented also for the websites administration?
That one is awfully slow (and sometimes timinig out) with 6000 sites ;)

@zawadzinski

(In [2720]) fixes #5708

@mattab
Piwik Open Source Analytics member

(In [2723]) Refs #5708 Fixing build

@mattab
Piwik Open Source Analytics member

(In [2724]) Refs #5708 Adding css file but still missing

but still missing the autocomplete.js which I don't have - Maciej?

@zawadzinski

(In [2727]) fixes #5708
added missing autocomplete.js

@mattab
Piwik Open Source Analytics member

(In [2732]) Refs #5708

@mattab
Piwik Open Source Analytics member

ts77, can you please contact me at matt att piwik.org? would love to hear a bit more about your use case of 6k sites, how is your experience with Piwi, and how we can improve it with that many websites. Thanks

@zawadzinski zawadzinski added this to the Piwik 0.6.5 milestone
@zawadzinski zawadzinski self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.