Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Piwik should use autoload (lazy load) classes instead of using require_once #620

Closed
mattab opened this Issue · 7 comments

2 participants

Matthieu Aubry Anthon Pang
Matthieu Aubry
Owner

Piwik should use autoload to automatically load the classes.

This would simplify the code, would make loading pages faster, as unecessary includes wouldn’t be loaded, and would greatly increase reusability of the code.

For example, Zend does it via``` Zend_Loader::registerAutoload();``` see the code on http://www.google.com/codesearch/p?hl=en#1oUPVh-C1Wg/trunk/eval/gx/zendframework/library/Zend/Loader.php&q=%22spl_autoload_register(array($class,%27autoload%27))%3B&l=32

Once implemented we can remove all require_once from all .php files. The includes for the Piwik_* (core/PluginsFunctions/*) shortcut functions would still be required and could all be merged in one include file.

Anthon Pang
Collaborator

Reference: http://www.zendframework.com/manual/en/performance.classloading.html

Suggests it would be as easy as adding this to index.php and piwik.php:

require_once 'Zend/Loader/Autoloader.php';
Zend_Loader_Autoloader::getInstance();
Anthon Pang
Collaborator

Silly me... RTFM, we would still have to define an autoloader callback to map classes in our namespace to actual files.

Matthieu Aubry
Owner

vipsoft, this ticket means:

  • using autoloading for all zend classes (if this is not already the case) by calling their autoloader
  • adding an autoloader in Piwik (can we somehow reuse the zend one?) and keep it as simple as possible (as in zend). This will most likely mean that a few classes will have to be moved/renamed. most classes should be OK as we used a similar structure to the zend structure.
Anthon Pang
Collaborator

(In [1220]) refs #620 - class renaming for consistency

Anthon Pang
Collaborator

(In [1221]) fixes #801, fixes #620 - implement autoloader; remove require_once
FrontController.php from ./index.php to test autoloader; add "false"
parameter to all class_exists() calls to not trigger autoloader

Anthon Pang
Collaborator

Confirming that [1220] was a global search and replace, including tests/*.

Anthon Pang
Collaborator

(In [1224]) refs #620, refs #803 - refactor autoloader into core/Loader.php (class
Piwik_Loader); remove unnecessary require_once in core/Common.php

Matthieu Aubry mattab added this to the Piwik 0.4.1 milestone
Anthon Pang robocoder was assigned by mattab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.