Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor segment handling/processing code to use Segment metadata classes when possible #6471

Closed
diosmosis opened this issue Oct 20, 2014 · 0 comments
Closed

Refactor segment handling/processing code to use Segment metadata classes when possible #6471

diosmosis opened this issue Oct 20, 2014 · 0 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Milestone
Long term

Comments

@diosmosis
Copy link
Member

As title. Using Piwik\Plugin\Segment instances in Segment.php & SegmentExpression.php will make the code cleaner. And it will allow us to more easily extend segmentation since the system will have more information at its disposal.
@diosmosis diosmosis mentioned this issue Oct 20, 2014
Closed
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Oct 20, 2014
@mattab mattab added this to the Mid term milestone Oct 20, 2014
@mattab mattab closed this as completed May 6, 2016
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
2 participants
@diosmosis @mattab