You can clone with
HTTPS or Subversion.
currently we don't check that the user has the zlib extension, but it is required for piwik to work correctly. We should add this check at installation.
added a patch to check extensions array for zlib.
i created another patch to reduce some code, only a suggestion... (if useful i will modify template too)
pebosi: it looks good with the exception of the changes from lines 488-499. It looks like the version requirement has been reversed; meanwhile, there's no check when the gd extension is missing.
my last patch also removes traling spaces...
pebosi, your patch is hard to read as you removed all white spaces etc.
can you please submit patch against trunk for only the lines you modified?
Attachment: next try
added patch version without removing whitespaces
assuming it has been tested, looks good to me
actually we should also add SPL to the list of required extension as of #176
Attachment: added spl check
Looks good (except for some minor formatting). Can you update the systemCheck template too and test it?
Attachment: updated patch
Attachment: updated template file, no patch
attached an updated patch and the first version of tempalte file (no patch). i replaced the help text of gd and extension-check with a link to http://piwik.org/docs/requirements/ (needs to be updated then)... only a suggestion ;)
Attachment: patch for template file
Sorry for not reviewing this sooner.
We should add/keep the informative help messages (e.g., Installation_SystemCheckPdoHelp). Perhaps:
$needed_functions = array(
'set_time_limit' => 'Installation_SystemCheckTimeLimitHelp',
'mail' => 'Installation_SystemCheckMailHelp',
(In ) fixes #700 - added check for zlib and SPL at install; based on pebosi's patch