Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

add a check for ZLIB extension at install #700

Closed
mattab opened this Issue · 19 comments

3 participants

Matthieu Aubry pebosi Anthon Pang
Matthieu Aubry
Owner

currently we don't check that the user has the zlib extension, but it is required for piwik to work correctly. We should add this check at installation.

pebosi

added a patch to check extensions array for zlib.

pebosi

i created another patch to reduce some code, only a suggestion... (if useful i will modify template too)

regards

Anthon Pang
Collaborator

pebosi: it looks good with the exception of the changes from lines 488-499. It looks like the version requirement has been reversed; meanwhile, there's no check when the gd extension is missing.

pebosi

my last patch also removes traling spaces...

Matthieu Aubry
Owner

pebosi, your patch is hard to read as you removed all white spaces etc.
can you please submit patch against trunk for only the lines you modified?

pebosi

Attachment: next try
700_gd_systemcheck.patch

pebosi

added patch version without removing whitespaces

Matthieu Aubry
Owner

assuming it has been tested, looks good to me

Matthieu Aubry
Owner

actually we should also add SPL to the list of required extension as of #176

pebosi

Attachment: added spl check
700_spl_systemcheck.patch

Anthon Pang
Collaborator

Looks good (except for some minor formatting). Can you update the systemCheck template too and test it?

pebosi

Attachment: updated patch
700_spl_systemcheck.2.patch

pebosi

Attachment: updated template file, no patch
systemCheck.tpl

pebosi

attached an updated patch and the first version of tempalte file (no patch). i replaced the help text of gd and extension-check with a link to http://piwik.org/docs/requirements/ (needs to be updated then)... only a suggestion ;)

regards

pebosi

Attachment: patch for template file
700_systemcheck_template.patch

Anthon Pang
Collaborator

Sorry for not reviewing this sooner.

  • Controller.php: ereg should be replaced with preg_match() for php 5.3
  • systemCheck.tpl: one link to http://piwik.org/docs/requirements/ should be sufficient
  • lang/en.php needs to be updated

We should add/keep the informative help messages (e.g., Installation_SystemCheckPdoHelp). Perhaps:

$needed_functions = array(
    'set_time_limit' => 'Installation_SystemCheckTimeLimitHelp',
    'mail'           => 'Installation_SystemCheckMailHelp',
);
Anthon Pang
Collaborator

(In [1368]) fixes #700 - added check for zlib and SPL at install; based on pebosi's patch

Matthieu Aubry mattab added this to the Piwik 0.4.3 milestone
Anthon Pang robocoder was assigned by mattab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.