Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Browser Arora is identified as Safari #715

Closed
anonymous-piwik-user opened this Issue · 6 comments

2 participants

@anonymous-piwik-user

This is because UserAgentParser lacks detection information for Arora. Besides, it looks strange to see Safari on Linux ;)

Example UA-String: "Mozilla/5.0 (X11; U; Linux; en-US) AppleWebKit/527+ (KHTML, like Gecko, Safari/419.3) Arora/0.6"

Maybe it is enough to include Arora to UserAgentParser::browsers array? I cannot test atm.

@anonymous-piwik-user

Attachment: Patch that makes Piwik identify Arora
useragentparser.diff

@anonymous-piwik-user

So, now i could. I did what i supposed in the description, tested it with the test.php and it is satisfying. Patch is attached.

@anonymous-piwik-user

Attachment: Browser image for UserSettings Plugin
AR.gif

@anonymous-piwik-user

Attachment: Assign Arora to KHTML family
UserSettings.diff

@anonymous-piwik-user

I yesterday evening how the browser family is detected... now i found out ;) Patch for UserSettings is now attached as well.

@mattab
Owner

fixed in [1125]

@anonymous-piwik-user anonymous-piwik-user added this to the RobotRock milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.