small inconsistency in javascript tracking API + documentation updates #816

Closed
mattab opened this Issue Jun 19, 2009 · 5 comments

2 participants

@mattab
Piwik Open Source Analytics member

As documented in: http://forum.piwik.org/index.php?showtopic=1079

we would like to:

  • resolve inconsistency; probably all setX should "replace" the list of classes, except the piwik_* default css class should always be in the list.
  • update the documentation to make it a bit more clear

Thanks!

@robocoder

Should we rename the functions for consistency too?

@mattab
Piwik Open Source Analytics member

yes it sounds like a good idea. what do you think about:

  • all functions accept either array or string names, or a simple string
  • all function named setBlahClasses()
  • we keep the old functions as briges and call the new ones - for backward compatbility for 0.4 users that already use the API
@robocoder

(In [1309]) refs #816 - added setDownloadClasses() and setLinkClasses() for consistency with setIgnoreClasses(), refactoring, and additional tests

@mattab
Piwik Open Source Analytics member

updated doc in http://piwik.org/docs/javascript-tracking/

thanks vipsoft

@mattab mattab added this to the Piwik 0.4.2 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment