Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Piwik should use Zend's session handling #828

Closed
anonymous-piwik-user opened this Issue · 13 comments

2 participants

@anonymous-piwik-user

I just tried to use Zend's session namespaces in a plugin, and failed. As it seems, the usage of session_start and of $_SESSION in Piwik prevents plugins from using this.
The attached patch should apply cleanly against 0.4.1, I replaced every occurance of $_SESSION with a new Zend session namespace named after the core component/plugin.
I tested the Installer plugin, should work fine.
Keywords: session handling zend

@robocoder
Collaborator

Yet you skipped core/Config.php and plugins/Dashboard?

@anonymous-piwik-user

my bad, forgot to add plugins/Dashboard to the patch. The comment in core/Config.php has been updated too.

@robocoder
Collaborator

Instead of removing session_start(), shouldn't it be replaced with Zend_Session::start()?

@anonymous-piwik-user

Look at libs/Zend/Session/Namespace.php, line 116 - it's called by the constructor anyway.

@robocoder
Collaborator

Right. And Zend_Session is indirectly used by Zend_Auth...

@robocoder
Collaborator

Ok, committing with some minor changes.

@robocoder
Collaborator

(In [1276]) Fixes #828 - use Zend_Session / Zend_Session_Namespace

@robocoder
Collaborator

(In [1286]) refs #828 - fix 'Trying to get property of non-object' error

@robocoder
Collaborator

PHP 5.2.0 bug causes:

Indirect modification of overloaded property Zend_Session_Namespace::$skipThisStep has no effect
in '/home/hostnser/sd/phpmv/plugins/Installation/Controller.php' at the line 212

Reference: http://framework.zend.com/issues/browse/ZF-1743

@robocoder
Collaborator

(In [1339]) fixes #885, refs #828 - dispatcher starts/resumes session unless PIWIK_ENABLE_SESSION_START=0

@robocoder
Collaborator

(In [1348]) fixes #828 - workaround ZF1743 and refactor session handling code

@anonymous-piwik-user anonymous-piwik-user added this to the Piwik 0.4.3 milestone
This was referenced
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.