Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

PHP 5.3 is throwing some notices #843

Closed
halfdan opened this Issue · 4 comments

2 participants

Fabian Becker Anthon Pang
Fabian Becker
Collaborator

I've just compiled PHP 5.3 and took a closer look at my log. I found the following notices/warnings:

23:13:59 PHP Warning: syntax error, unexpected $end, expecting TC_DOLLAR_CURLY or TC_QUOTED_STRING or '"' in /var/www/htdocs/piwik.c0demonkey.com/html/config/global.ini.php on line 145
in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker/Config.php on line 62
23:13:59 PHP Notice: Undefined index: record_statistics in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 304
23:13:59 PHP Notice: Undefined index: download_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 265
23:13:59 PHP Notice: Undefined index: outlink_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 280
23:13:59 PHP Notice: Undefined index: download_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 265
23:13:59 PHP Notice: Undefined index: outlink_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 280

As they should be easy to fix I selected the Milestone Piwik 0.4.2
Keywords: php notices

Anthon Pang
Collaborator

Can you please provide a patch?

Fabian Becker
Collaborator

Found out it's only a small adjustment in core/Tracker/Config.php.

Replace:

return $section

in __get($name) with

return count($section) > 0 ? $section : null;
Fabian Becker
Collaborator

Attachment: diff patch
Config.diff

Anthon Pang
Collaborator

(In [1265]) Fixes #843 - PHP 5.3 throwing some notices; patch from halfdan; thanks

Fabian Becker halfdan added this to the Piwik 0.4.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.