Unsorted table view in Length of Visits (patch included) #892

Closed
kurakin opened this Issue Jul 31, 2009 · 3 comments

2 participants

@kurakin

We have unsorted data in normal table view of Lenght of Visits for now. This looks slightly strange: see before.png attachment.

This simple patch solves the problem (see after.png attachment).

diff -Ebur piwik-4.2.orig/plugins/VisitorInterest/Controller.php piwik-4.2/plugins/VisitorInterest/Controller.php
--- piwik-4.2.orig/plugins/VisitorInterest/Controller.php   2009-07-08 08:19:14 +0400
+++ piwik-4.2/plugins/VisitorInterest/Controller.php    2009-07-31 20:59:21 +0400
@@ -25,6 +25,7 @@
        $view->init( $this->pluginName,  __FUNCTION__, "VisitorInterest.getNumberOfVisitsPerVisitDuration" );

        $view->setColumnsToDisplay( array('label','nb_visits') );
+       $view->setSortedColumn( 'label', 'asc' );
        $view->setColumnTranslation('label', Piwik_Translate('VisitorInterest_ColumnVisitDuration'));
        $view->disableSort();
        $view->disableExcludeLowPopulation();
@kurakin

Attachment: Unsorted Length of Visits / table view
before.png

@kurakin

Attachment: Length of Visits / table view, sorted by label
after.png

@robocoder

(In [1345]) fixes #892 - sort Length of Visits by label; thanks kurakin

@kurakin kurakin added this to the Piwik 0.4.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment