Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Avoid linebreaks within the labels in some Tag Clouds (patch included) #905

Closed
kurakin opened this Issue · 9 comments

3 participants

kurakin pebosi Anthon Pang
kurakin

I think, we should avoid of line breaks within the labels in some (not all) Tag Clouds views, especially in tables "Length of Visit" and "Pages per Visit". In the same time, line breaks within the labels in other Tag Cloud tables, such as "Visitor Browsers", "List of Keywords" and so on, should be allowed.

The proposed patch implements this behavior, offering the new table view property dont_break_labels. See before.png and after.png snapshots.

Take attention: this patch also offers little cosmetic improvement -- corrected line align in Tag Cloud. Left indents of lines are equal now (see snapshots).

kurakin

Attachment: Avoid linebreaks within the labels in Length of Visit and Pages per Visit tag clouds, plus a little cosmetic change
PiwikAvoidLinebreak.patch

kurakin

Attachment:
before.png

kurakin

Attachment:
after.png

pebosi

i think the additional function "disallowLabelsBreak" could be unattended. just do it with css.

kurakin

Replying to pebosi:

i think the additional function "disallowLabelsBreak" could be unattended. just do it with css.

I need to disallow linebreaks for two tables only: "Length of Visit" and "Pages per Visit". Linebreaks in all other tables should stay allowed. So I propose new property "dont_break_labels" to disable linebreaks selectively.

Thereto, disallowed linebreaks table can appears on the same page (dashboard) with allowed linebreaks table. These shouldn't affect each other. I don't no, how to solve it with pure css.

Anthon Pang
Collaborator

Would it be bad if we used the nowrap for all tag clouds?

kurakin

Replying to vipsoft:

Would it be bad if we used the nowrap for all tag clouds?

It should be good enough for me at this time (I tried this about 3 mounths ago).

However, the original solution proposed in this ticket is just little more flexible. Who knows... may be in the future Piwik will have the tables with very long labels, requiring linebreaks anyway...

Though, at this time the simple solution -- nowrap for all tag clouds -- is satisfying for me too.

Thankee for your attention.

Anthon Pang
Collaborator

tackle in conjunction with #946

Anthon Pang
Collaborator

In [1567], fixes #905 - apply css changes

kurakin kurakin added this to the Piwik 0.5 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.