Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

"Export as Image" redirects to a page without character encoding declaration #926

Closed
jpfleury opened this Issue · 3 comments

3 participants

Jean-Philippe Fleury pebosi Anthon Pang
Jean-Philippe Fleury

When we export a graph as an image, the page to which we are redirected doesn't contain any encoding declaration, so it can have some character encoding bugs, among other things with French sentences. For example:

<HTML>
<head>
<title>
Exporter au format Image
</title>
</head>
<body>
  <img title="Piwik Graph" src="data:image/[...]">
  <br>
  <br>
<p>
Pour enregistrer l'image sur votre ordinateur, faites un clic droit sur l'image et slectionnez "Enregistrer l'image sous..."
</p>
</body>
</html>

We should have at least a doctype and an encoding declaration. Example:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd ">
<HTML xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>
Exporter au format Image
</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
  <img title="Piwik Graph" src="data:image/[...]">
  <br>
  <br>
<p>
Pour enregistrer l'image sur votre ordinateur, faites un clic droit sur l'image et slectionnez "Enregistrer l'image sous..."
</p>
</body>
</html>
pebosi

Attachment: Created a little patch to add your proposals
piwik-926.patch

Anthon Pang
Collaborator

In [1399], fixes #926 - add encoding to generated 'Export as image' page

Anthon Pang
Collaborator

I introduced a regression. Fixed in [and 1406.

Jean-Philippe Fleury jpfleury added this to the Piwik 0.4.4 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.