Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Refactor saveLanguage from Installation and CoreUpdater controllers #939

Closed
robocoder opened this Issue · 2 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

In #759 and #937, the language selector posts to module=LanguagesManager, which appears odd if/when it appears in the address bar.

The selector's form action should depend on the context or be configurable.

Matthieu Aubry
Owner

Just to confirm, all the logic to deal with saving preferred language in session, etc. shoudl be done inside the API (and other modules should be able to statically call this API method in php)

Anthon Pang
Collaborator

In [1408], fixes #939 - refactor saveLanguage() from Installation and CoreUpdater controllers

Added Piwik_LanguagesManager_API::getLanguageForSession() and setLanguageForSession()

Anthon Pang robocoder added this to the Piwik 0.4.4 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.