"Loading data" position change not restored #950

Closed
robocoder opened this Issue Aug 25, 2009 · 7 comments

2 participants

@robocoder

In Actions|Outlinks, or Referers|Websites (for example), clicking on a row opens a subtable. The "Loading data" animation appears in the clicked row. However, when clicking "Next", the "Loading data" no longer appears in the table footer.

To be investigated with jquery update and documented in regression test procedures.

@robocoder

In 0.5.5:

  • On the UsersManager page, the 'Loading data' appears below the user table.
  • On the SitesManager page, the 'Loading data' appears above the site table.
@julienmoumne
Piwik Open Source Analytics member

On both pages, should it be below or above ?

@robocoder

re: comment:4 -- I don't think it matters (above vs below), so long as it is consistent.

@julienmoumne
Piwik Open Source Analytics member

Attachment:
950.patch

@julienmoumne
Piwik Open Source Analytics member

950.patch moves both loading and ajax success message above the user table in the users manager.

@robocoder

(In [2209]) refs #950

@robocoder

(In [2210]) fixes #950

@robocoder robocoder added this to the Piwik 0.6.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment