Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

sanitizeInputValues() gives a warning when type is set to 'numeric' and it must return the default #963

Closed
mgc8 opened this Issue · 4 comments

2 participants

@mgc8

The function accepts a $varType of 'numeric' which it interprets as either 'int' or 'float', and when the value does not match any of these, it must return the $varDefault parameter. However, the following line:

settype($varDefault, $varType);

gives a warning sine 'numeric' is not a valid settype parameter.

Keywords: sanitizeInputValues, settype, numeric

@robocoder

Propose to remove the 'numeric' case, and change all affected getRequestVar() calls to 'int'. (A quick grep shows it only used to get the 'h', 'm', and 's' parameters.)

@robocoder

Matt: in getRequestVar(), should we remove the 'array' case too? I don't believe it's possible to pass an array as a GET/POST parameter (except as something encoded, e.g., JSON, in which case, it would be a string).

@robocoder

scratch that last comment I forgot PHP handles returns an array when the URL contains parameters like this: x[]=1&x[]=3&x[]=4

@robocoder

In [1450], fixes #963 - remove 'numeric' as a getRequestVar() type

@mgc8 mgc8 added this to the Piwik 0.4.4 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.