Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

bz2 is missing from the list of downloadable files #995

Closed
anonymous-piwik-user opened this Issue · 5 comments

2 participants

@anonymous-piwik-user

In the list of downloadable file extensions inside piwik.js one very often used extensions is missing: bz2

// Extensions to be treated as download links
configDownloadExtensions = '7z|aac|arc|arj|asf|asx|avi|bin|csv|doc|exe|flv|gif|gz|gzip|hqx|jar|jpe?g|js|mp(2|3|4|e?g)|mov(ie)?|msi|msp|pdf|phps|png|ppt|qtm?|ra(m|r)?|sea|sit|tar|tgz|torrent|txt|wav|wma|wmv|wpd||xls|xml|z|zip',

@robocoder
Collaborator

Note: this is configurable via addDownloadExtensions() or setDownloadExtensions().

  • Consider adding 'bz2|tbz2' to the mix;
  • Re-visit the algorithm to make sure it's only matching on the filename and not URL parameters.
@robocoder
Collaborator

Update QUnit while you're at it.

http://dev.jquery.com/browser/trunk/qunit

@robocoder
Collaborator

In [1488], refs #995 - update Qunit

@robocoder
Collaborator

In [1508], fixes #995 - add bz2 (and tbz2) to list of recognized download extensions;
fix regression in [1488], where qunit no longer defines url() helper function;
fix bug in getLinkType() where it could match an extension in url params (false positive);
fixes #1007 - workaround Opera 9.22 parse bug, replacing // with new RegExp() syntax

@robocoder
Collaborator

In [1555], refs #995 - also handle .bz and .tbz (e.g., still used by freebsd ports)

@anonymous-piwik-user anonymous-piwik-user added this to the Piwik 0.4.4 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.