Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Change data fetch for OFC2 widgets #997

Closed
robocoder opened this Issue · 6 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

Currently, we pass a URL (data parameter) to the OFC2 charts pointing to a data feed.

Proposal:

  • use AJAX to retrieve the data and then pass the data to the Flash object via its load() method

Benefits:

  • increase browser responsiveness when changing date or site; some users report the browser stalls while loading data
  • better handle an invalid session, e.g., where user no longer logged in; see #975
  • decouples data feed retrieval from the flash object; potentially allows for non-flash, client-side charts to re-use the ofc data feed
  • could be extended to make a single request to the server for all the data feeds on that page
Matthieu Aubry
Owner

I would even suggest that, instead of using an ajax request, we could directly load the graph JSON data in the HTML calling the flash, and set this data to the graph object. This means that, to show the graph, you would just need one http request to request widget+graph data, + one request to fetch the SWF file if not already in cache.

Anthon Pang
Collaborator

In [1541], refs #997 - set content-type to application/json for OFC data feed

Anthon Pang
Collaborator

ToDo:

  • fix Widgetize (needs the data URL for embedding OBJECTs)
  • replace sendHttpRequest() with ... ???
Anthon Pang
Collaborator

Attachment: updated patch
997.patch

Anthon Pang
Collaborator

In [1543]:

  • fixes #997 - change data fetch for OFC2 widgets to load widget+data in a single fetch; moved HTML to graph.tpl; move JavaScript to common.js; fixed browser portability bug in findSWFGraph

  • fixes #1020 - only the last chart added to the dashboard can be saved locally (using the right-click pop-up menu to "Save Image Locally"); the footer icon link worked properly

  • fixes #947 - truncated translation string in Flash widget when "no data"; this is now styled consistently with "no data" for tables and tag clouds

related changes:

  • data-file (Flash parameter) renamed to x-data-file; this is used by Widgetize to provide the code to embed Flash OBJECTs
  • add translation strings for Flash detection
  • move some translation strings to JavaScript and enhance getJavascriptTranslations() to always generate 'General' translation strings
Anthon Pang
Collaborator

In [1575], refs #997 - reorder params slightly

In [1574], refs #997 - add config option; allow users to revert to previous behavior

Anthon Pang robocoder added this to the Piwik 0.5 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.