Skip to content

Loading…

adding support for windows phone 7 version 7.5 #1

Closed
wants to merge 2 commits into from

2 participants

@thirashima

UserAgentClass fails to return an OS for 7.5 user agent strings.

Tom Hirashima added some commits
@robocoder robocoder closed this
@robocoder

We initially added detection specifically for Windows Phone 7.5 (in http://dev.piwik.org/trac/ticket/2808), but later decided to consolidate and drop the OS version (given market share, and general inconsistency; Windows desktop OS versions continue to be detected though). http://dev.piwik.org/trac/ticket/2824

@cbonte cbonte added a commit to cbonte/piwik that referenced this pull request
@cbonte cbonte provide a sample test to benchmark the impact of caching the dates
As a reference on a laptop with :
Intel(R) Core(TM) i7-2630QM CPU @ 2.00GHz
Python 2.7.7rc1
Debian SID - Linux 3.14-1-amd64 #1 SMP Debian 3.14.4-1 (2014-05-13) x86_64 GNU/Linux

The results are :
cache   : 647.914 ms
nocache : 21440.542 ms
3b33a37
@anonymous-piwik-user anonymous-piwik-user referenced this pull request
Closed

Use to work #750

@halfdan halfdan referenced this pull request
Closed

PHP 5.3 breaks Piwik #844

@mikeSimonson mikeSimonson referenced this pull request
Closed

sql bug #915

@lehrer lehrer referenced this pull request
Closed

Whois Live Plugin #1317

@anonymous-piwik-user anonymous-piwik-user referenced this pull request
Closed

Logout Error #3673

@EPinci EPinci referenced this pull request
Closed

Openbasedir regression #5325

This was referenced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 11, 2011
  1. add support for Windows Phone 7.5

    Tom Hirashima committed
  2. fix whitespace.

    Tom Hirashima committed
Showing with 1 addition and 0 deletions.
  1. +1 −0 libs/UserAgentParser/UserAgentParser.php
View
1 libs/UserAgentParser/UserAgentParser.php
@@ -243,6 +243,7 @@ class UserAgentParser
'Windows 95' => 'W95',
'Windows Phone OS 7.0' => 'WP7',
+ 'Windows Phone OS 7.5' => 'WP7',
'Windows Mobile 6.5' => 'W65',
'Windows Mobile 6.1' => 'W61',
'Windows CE' => 'WCE',
Something went wrong with that request. Please try again.