Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection for empty keywords for referring search engines #10163

Merged
merged 2 commits into from Jul 13, 2016

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 18, 2016

empty keyword urls can now be defined in search engine definitions.

matomo-org/searchengine-and-social-list#10 needs to be merged, and piwik/searchengine-and-social-list dependency needs to be updated before merging this PR

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label May 18, 2016
@sgiehl sgiehl force-pushed the improveemptykeyworddetection branch 3 times, most recently from 8dbb096 to ab8eb5d Compare May 19, 2016 19:03
@sgiehl sgiehl changed the title Improve detection for empty keywords for referring seach engines Improve detection for empty keywords for referring search engines May 20, 2016
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels May 24, 2016
@mattab mattab added this to the 2.16.2 milestone May 27, 2016
@sgiehl sgiehl force-pushed the improveemptykeyworddetection branch from ab8eb5d to ec7ecd5 Compare July 3, 2016 12:43
@mattab
Copy link
Member

mattab commented Jul 13, 2016

Review:

  • LGTM
  • as you wrote the composer dev-improveemptykeyworddetection needs to refs the version instead
  • was there maybe an issue that this PR fixes?

@sgiehl sgiehl force-pushed the improveemptykeyworddetection branch from ec7ecd5 to 707598f Compare July 13, 2016 17:39
@sgiehl
Copy link
Member Author

sgiehl commented Jul 13, 2016

I've released a new version of piwik/searchengine-and-social-list and updated the dependency. As soon as the tests passes, I'll merge.
Related issue was #9438. But that has already been closed

@sgiehl sgiehl merged commit f6c3da4 into master Jul 13, 2016
@sgiehl sgiehl deleted the improveemptykeyworddetection branch July 13, 2016 18:08
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants