Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CliMulti: If process or output size is unexpected large, declare it as finished #6667

Merged
merged 3 commits into from Nov 17, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 13, 2014

#6617 Declares a process as finished as soon as a PID file is > 500bytes

(contains only PID) and output file is > 100MB (which should usually
not be larger than 100KB or 1MB) to prevent files growing up to many
GBs. I added unit and integration tests for the file size detection. It is
now possible to mock the methods file_exists and filesize although very
simple so far. Later we can allow to define callbacks to define different
return values for different files or we can use something like vfsStream

tsteur and others added 3 commits November 13, 2014 04:16
…shed

Declares a process as finished as soon as a PID file is > 500bytes
(contains only PID) and output file is > 100MB (which should usually
not be larger than 100KB or 1MB) to prevent files growing up to many
GBs. I added unit and integration tests for the file size detection. It is
now possible to mock the methods file_exists and filesize although very
simple so far. Later we can allow to define callbacks or to define different
return values for different files or we can use something like vfsStream
mattab pushed a commit that referenced this pull request Nov 17, 2014
CliMulti: If process or output size is unexpected large, declare it as finished
@mattab mattab merged commit beac446 into master Nov 17, 2014
@mattab mattab deleted the 6617 branch November 18, 2014 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants