Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manage goals" page in the reporting menu #7704

Merged
merged 3 commits into from Apr 21, 2015
Merged

"Manage goals" page in the reporting menu #7704

merged 3 commits into from Apr 21, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Apr 19, 2015

Fixes #7345

This replaces the "Add a new goal" link with "Manage goals" instead:

capture d ecran 2015-04-20 a 01 51 48

@mnapoli mnapoli added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review labels Apr 19, 2015
@mnapoli mnapoli added this to the Piwik 2.13.0 milestone Apr 19, 2015

$order = 1;

if (count($goals) == 0) {

$menu->addItem($mainGoalMenu, '', $linkToAddNewGoal, 25);
$menu->addItem($mainGoalMenu, '', $linkToManageGoals, 25);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when there are no goal, why not leave menu "Add new goal" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we already land on the "manage goals" page anyway if there are no goals? (the manage goals page already has a "add a new goal button, having another way to do it might be confusing?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to make it easy to users to create their first goals since it's such a key feature of Piwik. linking to 'Add new goal' directly removes one extra click and puts users closer to better data insights using Piwik 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I see I've changed the menu links

@mattab
Copy link
Member

mattab commented Apr 21, 2015

(optional) you may change the link in http://demo.piwik.org/index.php?module=CoreHome&action=index&date=previous7&period=range&idSite=1#/module=Goals&action=addNewGoal&date=previous7&period=range&idSite=1 on Manage Goals to load this new sub-page (currently it links to the "Manage goals in user view" which forces page refresh)

definitely like the idea to replace the menu Add new goal by Manage Goals

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 21, 2015

@mattab How can I make this link link to the "AJAX version" of "Manage Goals" (instead of loading the Administration screen)?

@mattab
Copy link
Member

mattab commented Apr 21, 2015

maybe something like href="javascript:broadcast.propagateAjax('module=Goals&action=xxxx')" ?

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 21, 2015

Thanks, the link is fixed

mattab pushed a commit that referenced this pull request Apr 21, 2015
"Manage goals" page in the reporting menu
@mattab mattab merged commit 5752c62 into master Apr 21, 2015
@mnapoli mnapoli deleted the manage-goals branch April 21, 2015 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants