New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Manage goals" page in the reporting menu #7704
Conversation
|
||
$order = 1; | ||
|
||
if (count($goals) == 0) { | ||
|
||
$menu->addItem($mainGoalMenu, '', $linkToAddNewGoal, 25); | ||
$menu->addItem($mainGoalMenu, '', $linkToManageGoals, 25); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when there are no goal, why not leave menu "Add new goal" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we already land on the "manage goals" page anyway if there are no goals? (the manage goals page already has a "add a new goal button, having another way to do it might be confusing?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea is to make it easy to users to create their first goals since it's such a key feature of Piwik. linking to 'Add new goal' directly removes one extra click and puts users closer to better data insights using Piwik 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see I've changed the menu links
(optional) you may change the link in http://demo.piwik.org/index.php?module=CoreHome&action=index&date=previous7&period=range&idSite=1#/module=Goals&action=addNewGoal&date=previous7&period=range&idSite=1 on definitely like the idea to replace the menu Add new goal by Manage Goals |
maybe something like |
Thanks, the link is fixed |
"Manage goals" page in the reporting menu
Fixes #7345
This replaces the "Add a new goal" link with "Manage goals" instead: