Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emails validation with unknown TLD #8400

Merged
merged 1 commit into from Jul 22, 2015
Merged

Conversation

barbushin
Copy link
Contributor

refs #8391

'Zend_Validate_EmailAddress' => function () {
return new \Zend_Validate_EmailAddress(array(
'hostname' => new \Zend_Validate_Hostname(array(
'tld' => false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there other settings we could disable from email validation, to try and accept as many 'valid' emails as possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all available settings, and I think tld=false is the only one we need to use. There was a problem with out-dated list of TLD zones that Zend used to validate email.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, sounds good 👍

@barbushin barbushin added the Needs Review PRs that need a code review label Jul 22, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Jul 22, 2015

👍 failed UI tests are because of outdated UI screenshots (probably the branch was created before those screenshots were updated)

@mnapoli mnapoli added this to the 2.14.2 milestone Jul 22, 2015
mnapoli added a commit that referenced this pull request Jul 22, 2015
Fix emails validation with unknown TLD
@mnapoli mnapoli merged commit 95ce040 into master Jul 22, 2015
@mnapoli mnapoli deleted the 8391_email_tld_validation branch July 22, 2015 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants