Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added option to set Navigation icon colors in camera.js, using buttons and font-awsome.css #9

Open
wants to merge 18 commits into
from

Conversation

Projects
None yet
4 participants

OK, bear with me since this is my first pull request and I am a jQuery novice!

I love your slider but didn't like the limitations of using images for navigation UI.
Rather than have the navigation icons use a sprite and CSS for skin colors, I added an option to be able to set the icon colors in camera.js. By changing the next, prev, play and stop as well as the thumb_next, thumb_prev to use icons from font-awsome.css, https://github.com/FortAwesome/Font-Awesome, and some button CSS code from Twitter bootstrap, https://github.com/twitter/bootstrap, one can set these icons to any color as a setting in Camera, "buttonColor".
Still some bugs ( it seems that if there are two sliders on a page, the colors are the same for both!)

Mike

Owner

pixedelic commented May 23, 2012

Hi Mike,

thank you... at the moment I'm very busy, I hope to take a look to your
work as soon as possible

Manuel :-)

2012/5/21 Mike Sozanski <
reply@reply.github.com

OK, bear with me since this is my first pull request and I am a jQuery
novice!

I love your slider but didn't like the limitations of using images for
navigation UI.
Rather than have the navigation icons use a sprite and CSS for skin
colors, I added an option to be able to set the icon colors in camera.js.
By changing the next, prev, play and stop as well as the thumb_next,
thumb_prev to use icons from font-awsome.css,
https://github.com/FortAwesome/Font-Awesome, and some button CSS code
from Twitter bootstrap, https://github.com/twitter/bootstrap, one can set
these icons to any color as a setting in Camera, "buttonColor".
Still some bugs ( it seems that if there are two sliders on a page, the
colors are the same for both!)

Mike

You can merge this Pull Request by running:

git pull https://github.com/macsupport/Camera master

Or you can view, comment on it, or merge it online at:

#9

-- Commit Summary --

  • Update scripts/camera.js
  • Added CSS for buttons. Removed CSS for Skins since skin color added to
    camera.js
  • fix
  • Updated Zip
  • Added Description for buttonColor
  • Description of buttonColor
  • Deleted Zip
  • Updated Zip
  • Fixed play/stop nab button position
  • Updated camera.min.js
  • Added font-awsome.css
  • Ignore .DS_Store
  • Updated zip
  • Changed default button icon color
  • ignore DS_Store
  • Ignore DS_Store

-- File Changes --

A .gitignore (2)
M camera.zip (0)
A css/.DS_Store (0)
M css/camera.css (736)
A css/font-awesome.css (239)
A css/font/fontawesome-webfont.eot (0)
A css/font/fontawesome-webfont.svg (175)
A css/font/fontawesome-webfont.svgz (0)
A css/font/fontawesome-webfont.ttf (0)
A css/font/fontawesome-webfont.woff (0)
M demo/basic.htm (10)
M demo/features.htm (4)
M demo/fullscreen.htm (4)
A scripts/.DS_Store (0)
M scripts/camera.js (17)
M scripts/camera.min.js (5)

-- Patch Links --

https://github.com/pixedelic/Camera/pull/9.patch
https://github.com/pixedelic/Camera/pull/9.diff


Reply to this email directly or view it on GitHub:
#9

Manuel Masia – Pixedelic
via Brescia, 15
47841 - Cattolica (RN)
p. iva 03718310406

http://www.pixedelic.com
http://www.consorziocreativo.com
http://themeforest.net/user/pixedelic
https://twitter.com/#!/pixedelic
http://dribbble.com/pixedelic
http://www.facebook.com/pages/Consorzio-Creativo/209711855772

Owner

pixedelic commented May 23, 2012

Is it possible to see something in action?

Here is a sample page using "magenta":

http://macosxsupport.com/camera/

I added the option to have the background of the pagination circles also use the buttonColor setting, but I think it would be better to have the selected "dot" be the color rather than the background in the future.

(The javascript is all in camera.js)

Note: This example has an icon in the caption for a Lightbox popup, not part of my pull request, just a feature I wanted to add for a gallery.

think i prefer sprites

Hi Manuel,

Thanks for your Camera plugin. I have one issue and one suggestion.
Issue: When I have more than one video present in the slider, Internet Explorer (IE9) is skipping currently playing video and sliding to next one forcefully.
Suggestion: Adding an option to open the image or video in a popup on click of the slider content.

Looking forward for the next release with fixes.

Muralikrishna P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment