Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doubletap to like #1259

Merged
merged 10 commits into from May 7, 2019

Conversation

Projects
None yet
3 participants
@talon
Copy link
Contributor

commented May 3, 2019

I attempted to add the vue-touch@next npm module. I don't know where it should be Vue.use'd but I put it in bootstrap.js for now. Assuming the plugin registers then there are also now v-on:doubletap="likeStatus(status, $event)" directives for all the status containers I could find.

I'm new to the project so I haven't been able to test this locally yet but perhaps someone can help me finish this PR

dansup and others added some commits May 2, 2019

@dansup

This comment has been minimized.

Copy link
Member

commented May 4, 2019

@talon Thanks for the PR, not sure about double tap to like. Will get some feedback from the community before a decision is made.

Edit: I made a poll! https://mastodon.social/@dansup/102034862729867911

@dansup dansup changed the base branch from dev to frontend-ui-refactor May 4, 2019

Show resolved Hide resolved resources/assets/js/bootstrap.js Outdated
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved resources/assets/js/components/PostComponent.vue Outdated
@ealgase

This comment has been minimized.

Copy link

commented May 4, 2019

@talon Thanks for the PR, not sure about double tap to like. Will get some feedback from the community before a decision is made.

Thanks for considering community feedback!

talon and others added some commits May 4, 2019

@dansup

dansup approved these changes May 7, 2019

@dansup dansup merged commit 8dbe44d into pixelfed:frontend-ui-refactor May 7, 2019

@talon talon deleted the talon:feat/double-tap-to-like branch May 7, 2019

dansup added a commit that referenced this pull request May 7, 2019

dansup added a commit that referenced this pull request May 7, 2019

Merge pull request #1277 from pixelfed/frontend-ui-refactor
Refactor #1259, add double tap to like and deprecate lightbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.