Permalink
Commits on Jan 15, 2016
  1. Add changelog entry for #1512

    soulcutter committed Jan 15, 2016
  2. Merge pull request #1512 from Ferdy89/do_not_leak_test_unit_methods_a…

    …fter_rails_4
    
    Do not leak TestUnit specific methods after Rails 4
    soulcutter committed Jan 15, 2016
Commits on Jan 14, 2016
  1. Merge pull request #1526 from eliotsykes/favor-https-over-git-protocol

    Favor https: over git: protocol remotes
    JonRowe committed Jan 14, 2016
  2. Favor https: over git: protocol remotes

    From Bundler docs on Security:
    
    > http:// and git:// URLs are insecure. A man-in-the-middle attacker
    could tamper with the code as you check it out, and potentially supply
    you with malicious code instead of the code you meant to check out.
    Because the :github shortcut uses a git:// URL in Bundler 1.x versions,
    we recommend using using HTTPS URLs or overriding the :github shortcut
    with your own HTTPS git source.
    
    Source: http://bundler.io/git.html
    eliotsykes committed Jan 14, 2016
Commits on Jan 8, 2016
  1. Merge pull request #1523 from rspec/replace-version-checker-with-comp…

    …arable-version
    
    Use RSpec::Support::ComparableVersion for capybara version check
    JonRowe committed Jan 8, 2016
  2. Use RSpec::Support::ComparableVersion for capybara version check

    ... so that we can remove RSpec::Support::VersionChecker in rspec-support.
    yujinakayama committed Jan 4, 2016
Commits on Jan 6, 2016
  1. Merge pull request #1521 from rspec/update-travis-build-scripts-2016-…

    …01-06-for-master
    
    Updates from rspec-dev (2016-01-06)
    myronmarston committed Jan 6, 2016
Commits on Jan 5, 2016
  1. Do not leak TestUnit specific methods after Rails 4

    * TestUnit requires the build_message method to be defined for its
      assertions to work properly. After Rails 4, Minitest is used instead
      of TestUnit so the method should not be included anymore. This is
      problematic because when using RSpec configured with
    
          config.expect_with :test_unit
    
      the TestUnit assertions try to call build_message on the
      MinitestAssertionAdapter which will crash.
    Ferdy89 committed Dec 29, 2015
  2. Merge pull request #1518 from rspec/update-travis-build-scripts-2016-…

    …01-04-for-master
    
    Updates from rspec-dev (2016-01-04)
    soulcutter committed Jan 5, 2016
Commits on Jan 4, 2016
  1. Merge pull request #1516 from rspec/update-travis-build-scripts-2016-…

    …01-01-for-master
    
    Updates from rspec-dev (2016-01-01)
    yujinakayama committed Jan 4, 2016
  2. Remove debugger gem from example app Gemfile

    It's essentially not needed for our test and tend to cause installation problem.
    yujinakayama committed Jan 3, 2016
Commits on Jan 3, 2016
  1. Pin nokogiri to 1.6.7.1

    yujinakayama committed Jan 3, 2016
Commits on Jan 1, 2016
Commits on Dec 30, 2015
Commits on Dec 24, 2015
  1. Merge pull request #1510 from rspec/pin_nokogiri

    Prevent bad version of nokogiri and fix build
    JonRowe committed Dec 24, 2015
  2. prevent bad version of nokogiri

    JonRowe committed Dec 24, 2015
  3. Merge pull request #1492 from rspec/rails-5-support-patches

    Rails 5 support patches
    JonRowe committed Dec 24, 2015
Commits on Dec 19, 2015
  1. Merge pull request #1508 from rspec/1403_singular_generator

    #1503 with changelog.
    samphippen committed Dec 19, 2015
  2. Add a changelog entry for #1503

    Closes #1403
    samphippen committed Dec 19, 2015
  3. Add `--singularize` flag on feature generators

    Liss McCabe committed with samphippen Dec 17, 2015
  4. Singularize classes for feature names

    Fixes issue #1403
    Liss McCabe committed with samphippen Dec 10, 2015
  5. Fixup have_http_status matcher header assignment.

    We now have to mutate, instead of assigning, headers in the resp.headers
    property here.
    samphippen committed Dec 19, 2015
  6. Fix up view example groups.

    `controller.request.path_parameters` is no longer able to be directly
    assigned to, but should instead be mutated. Here, we take what we were
    doing before with the assignment and doing a reverse merge instead,
    which has the same affect.
    samphippen committed Dec 19, 2015
  7. Setup compatability with the `rails-controller-testing` gem.

    This fixes a number of spec types, and requires the added setup lines.
    As a note, this is a soft, not hard dependency. We don't get automatic
    compatability. Instead, users will have to add the gem to their Gemfile
    if they want that functionality.
    samphippen committed Dec 19, 2015
  8. Fixup mailer spec generators for Rails 5.

    Rails 5 now automatically appends the word `Mailer` to generated mailer
    classes. We now have to do that too.
    samphippen committed Dec 19, 2015
  9. Change render_views specs to match more generic headers.

    In Rails 5, the word "Listing" has been removed from the autogenerated
    scaffold header, so here we match with a simple regex.
    samphippen committed Dec 19, 2015
  10. Fixup response code handling in `have_http_status`.

    This now consistently calls `.to_i` on response codes, which ensures
    they're always an integer (accross rails versions). Additionally I
    replaced a number of `333` codes with `308`s. The reasoning for this is
    that rack no longer accepts non-spec 3xx codes in it's `redirect?`
    methods, which breaks our tests.
    samphippen committed Dec 19, 2015
  11. Switch mailer examples on rails version.

    Rails 5 changes the class name generated for mailers from looking like
    `Thing` to looking like `ThingMailer`. Our cukes depend on this name,
    and so break as is. Here, I've added two tags, `@pre_rails_5` and
    `@post_rails_5`.
    
    The modification to the rakefile changes how we execute cukes based on
    the rails version, filtering to the correct cukes.
    samphippen committed Dec 19, 2015
  12. Fix up dependencies for the example app.

    We need the rails controller testing gem to be able to test the sample
    app. We also don't want it to run web console at all.
    samphippen committed Dec 19, 2015
  13. Add explicit git master web console dependency

    This is done because rails 5 needs a newer version of rails console than
    will be installed by the implicit dependencies resolved via rubygems. It
    is also only added to the development group because we do not want
    webconsole to get in the way of any of the specs that we run.
    samphippen committed Dec 19, 2015