From 3861feba420bfa7ce86a47ba7d853b4e988c1686 Mon Sep 17 00:00:00 2001 From: Hannah Troisi Date: Fri, 22 Apr 2022 09:49:53 -0700 Subject: [PATCH 1/2] Add more Java instructions to the profiler tutorial. Signed-off-by: Hannah Troisi --- content/en/04-tutorials/01-pixie-101/06-profiler.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/en/04-tutorials/01-pixie-101/06-profiler.md b/content/en/04-tutorials/01-pixie-101/06-profiler.md index 15cda1aa..8d9171f4 100644 --- a/content/en/04-tutorials/01-pixie-101/06-profiler.md +++ b/content/en/04-tutorials/01-pixie-101/06-profiler.md @@ -19,7 +19,7 @@ You will need a Kubernetes cluster with Pixie installed. If you do not have a cl ### Enabling Java Support -Java support is a beta feature and must be manually enabled during the deployment of Pixie. +Java support is available for Pixie vizier version 0.10.22+. Instructions for identifying and updating your vizier version can be found [here](https://docs.px.dev/reference/admin/updating-pixie/#updating-pixie-cloud-and-vizier). Java support is a beta feature and must be manually enabled during the deployment of Pixie. To enable Java support when deploying Pixie with the [Pixie CLI](/installing-pixie/install-schemes/cli/), run: @@ -33,6 +33,8 @@ To enable Java support when deploying Pixie with [Helm](/installing-pixie/instal helm install pixie pixie-operator/pixie-operator-chart --set deployKey= --set clusterName= --namespace pl --create-namespace --set dataCollectorParams.customPEMFlags.PL_PROFILER_JAVA_SYMBOLS=true ``` +For best results, run Java applications with `-XX:+PreserveFramePointer`. + ## Setup We are going to be working with GCP's [Online Boutique](https://github.com/GoogleCloudPlatform/microservices-demo), a microservices demo application for a web-based e-commerce app where users can browse and purchase items. From 51a9517c268924caea8023ce64dc0825356766a5 Mon Sep 17 00:00:00 2001 From: Hannah Troisi Date: Fri, 22 Apr 2022 10:14:09 -0700 Subject: [PATCH 2/2] address Omid's comments Signed-off-by: Hannah Troisi --- content/en/04-tutorials/01-pixie-101/06-profiler.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/content/en/04-tutorials/01-pixie-101/06-profiler.md b/content/en/04-tutorials/01-pixie-101/06-profiler.md index 8d9171f4..aaa4199f 100644 --- a/content/en/04-tutorials/01-pixie-101/06-profiler.md +++ b/content/en/04-tutorials/01-pixie-101/06-profiler.md @@ -19,7 +19,11 @@ You will need a Kubernetes cluster with Pixie installed. If you do not have a cl ### Enabling Java Support -Java support is available for Pixie vizier version 0.10.22+. Instructions for identifying and updating your vizier version can be found [here](https://docs.px.dev/reference/admin/updating-pixie/#updating-pixie-cloud-and-vizier). Java support is a beta feature and must be manually enabled during the deployment of Pixie. +Java support is a beta feature available in Pixie vizier version 0.10.22+, and must be manually enabled during the deployment of Pixie. + + + Instructions for identifying and updating your Pixie vizier version can be found here. + To enable Java support when deploying Pixie with the [Pixie CLI](/installing-pixie/install-schemes/cli/), run: