Detect/sanitize homoglyphs in Vizier names #1653
Labels
area/control-plane
good first issue
Good for newcomers
kind/feature
New feature or request
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Is your feature request related to a problem? Please describe.
Users can currently specify a name for their Vizier by passing in the cluster name at deploy time. For example
px deploy --cluster_name=test.Vizier names are unique across the control plane. So, if someone were to already have a cluster name of
test, the cluster would be assigned a name oftest_<random-hash>. This is all done here when a Vizier connects to the control plane: https://github.com/pixie-io/pixie/blob/main/src/cloud/vzmgr/controllers/server.go#L775There's a possibility that someone could confuse another user by trying to deploy a cluster name using homoglyphs. For example: "cluster" vs "clυster". Users may mistakenly believe that "clυster" is cluster which they are looking for.
Describe the solution you'd like
When a user inputs a cluster name with homoglyphs, we should detect that and sanitize the name. For example, replacing υ with u.
Describe alternatives you've considered
Rather than sanitization, we could just choose to present the Vizier name differently in the UI so the characters are visually different.
The text was updated successfully, but these errors were encountered: