Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memory Limiter in Kelvin #471

Open
aimichelle opened this issue Jun 24, 2022 · 2 comments
Open

Add Memory Limiter in Kelvin #471

aimichelle opened this issue Jun 24, 2022 · 2 comments
Assignees
Labels
area/query kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aimichelle
Copy link
Member

Is your feature request related to a problem? Please describe.
Some users are applying a memory limit on Kelvin to avoid memory spikes when running large queries. Using the K8s memory limit will cause the Kelvin to OOMKill when it does run these larger queries. This can make it appear that the Pixie deployment is unstable.

Describe the solution you'd like
Rather than trying to process all incoming data from the PEMs, Kelvin should respect the memory limit and only process results up to what it can fit in memory. This will prevent the Kelvin from OOMKilling. In the future we should also show a warning message to inform users they are not seeing the full results.

@aimichelle aimichelle added kind/feature New feature or request needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/query labels Jun 24, 2022
@zasgar zasgar added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 27, 2022
@zasgar zasgar added this to the 2022-Q3 milestone Jun 27, 2022
@nr-pmoses
Copy link

@aimichelle please can I ask if we are on track to complete the memory fix for this issue ASAP? Thanks

@JamesMBartlett
Copy link
Member

HI @nr-pmoses,
We have an implementation of this feature but the performance overhead was too significant. We are currently reevaluating our options to implement this without significant overhead. I think realistically, we're probably looking at 1-2 months before this feature lands.

@zasgar zasgar modified the milestones: 2022-Q3, 2022-Q4 Sep 23, 2022
@vihangm vihangm removed this from the 2022-Q4 milestone Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants