From 2bef274383c4320d7a84c6f7d6714e9589dbf6b2 Mon Sep 17 00:00:00 2001
From: Pete Stevenson <jps@pixielabs.ai>
Date: Mon, 8 May 2023 11:19:43 -0700
Subject: [PATCH 1/2] Write pprof from stirling profiler.

Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
---
 src/stirling/binaries/BUILD.bazel          |  1 +
 src/stirling/binaries/stirling_profiler.cc | 33 +++++++++++++++-------
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/src/stirling/binaries/BUILD.bazel b/src/stirling/binaries/BUILD.bazel
index 0ce3b98c230..f9b97bef9aa 100644
--- a/src/stirling/binaries/BUILD.bazel
+++ b/src/stirling/binaries/BUILD.bazel
@@ -96,6 +96,7 @@ pl_cc_binary(
     name = "stirling_profiler",
     srcs = ["stirling_profiler.cc"],
     deps = [
+        "//src/shared/pprof:cc_library",
         "//src/stirling/source_connectors/perf_profiler:cc_library",
     ],
 )
diff --git a/src/stirling/binaries/stirling_profiler.cc b/src/stirling/binaries/stirling_profiler.cc
index 77f5eb8df52..886ec0fdda9 100644
--- a/src/stirling/binaries/stirling_profiler.cc
+++ b/src/stirling/binaries/stirling_profiler.cc
@@ -16,35 +16,48 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+#include <sys/sysinfo.h>
+
 #include <csignal>
 #include <iostream>
 #include <thread>
 
 #include "src/common/base/base.h"
+#include "src/shared/pprof/pprof.h"
 #include "src/shared/upid/upid.h"
 #include "src/stirling/core/unit_connector.h"
 #include "src/stirling/source_connectors/perf_profiler/perf_profile_connector.h"
-#include "src/stirling/source_connectors/perf_profiler/stack_traces_table.h"
 
 using ::px::Status;
 
 DEFINE_uint32(time, 30, "Number of seconds to run the profiler.");
+DEFINE_string(pprof_pb_file, "profile.pb", "File path for pprof protobuf output.");
+DECLARE_uint32(stirling_profiler_stack_trace_sample_period_ms);
 
 namespace px {
 namespace stirling {
 
 class Profiler : public UnitConnector<PerfProfileConnector> {
  public:
-  Status PrintData() {
+  Status WritePProf() {
     // Build the stack traces histogram.
     PX_RETURN_IF_ERROR(BuildHistogram());
 
-    // Print the stack traces histogram.
-    // TODO(jps): replace this with a pprof proto file writer.
-    // 15x: libc.so;main;foo;bar
-    // 12x: libc.so;main;foo;qux
-    for (const auto& [str, count] : histo_) {
-      LOG(INFO) << count << "x: " << str;
+    // Create the pprof profile.
+    const uint32_t num_cpus = get_nprocs_conf();
+    const uint32_t period_ms = FLAGS_stirling_profiler_stack_trace_sample_period_ms;
+    const auto pprof_pb = px::shared::CreatePProfProfile(num_cpus, period_ms, histo_);
+
+    // Write the pprof profile to disk.
+    std::fstream outfile(FLAGS_pprof_pb_file, std::ios::out | std::ios::trunc | std::ios::binary);
+    if (!outfile.is_open()) {
+      char const* const err_msg = "Failed to open output file: $0.";
+      return error::Internal(absl::Substitute(err_msg, FLAGS_pprof_pb_file));
+    }
+
+    if (!pprof_pb.SerializeToOstream(&outfile)) {
+      char const* const err_msg = "Failed to write pprof protobuf to file: $0.";
+      return error::Internal(absl::Substitute(err_msg, FLAGS_pprof_pb_file));
     }
     return Status::OK();
   }
@@ -101,8 +114,8 @@ Status RunProfiler() {
   // Stop collecting data and do a final read out of eBPF perf buffer & maps.
   PX_RETURN_IF_ERROR(g_profiler->Stop());
 
-  // Print the info. We will replace this with a pprof proto file write out.
-  PX_RETURN_IF_ERROR(g_profiler->PrintData());
+  // Write a pprof proto file.
+  PX_RETURN_IF_ERROR(g_profiler->WritePProf());
 
   // Phew. We are outta here.
   return Status::OK();

From ff33d234c3073f2a58c509a85b47162230251806 Mon Sep 17 00:00:00 2001
From: Pete Stevenson <jps@pixielabs.ai>
Date: Mon, 8 May 2023 14:06:54 -0700
Subject: [PATCH 2/2] Comment.

Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
---
 src/stirling/binaries/stirling_profiler.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/stirling/binaries/stirling_profiler.cc b/src/stirling/binaries/stirling_profiler.cc
index 886ec0fdda9..db0bd62b685 100644
--- a/src/stirling/binaries/stirling_profiler.cc
+++ b/src/stirling/binaries/stirling_profiler.cc
@@ -40,7 +40,7 @@ namespace stirling {
 class Profiler : public UnitConnector<PerfProfileConnector> {
  public:
   Status WritePProf() {
-    // Build the stack traces histogram.
+    // Build stack traces histogram.
     PX_RETURN_IF_ERROR(BuildHistogram());
 
     // Create the pprof profile.