Docs: backfill MADR 4.0 decisions/ for load-bearing decisions#226
Merged
Conversation
Reconstructs 15 ADRs from merged PRs, issues, and the user-facing docs. Each entry cites its primary source inline so claims can be traced back to the originating PR description, issue body, or doc passage. Covers licensing, the rule taxonomy + naming, all-frames execution, DOM-marker registry, lib/rules import boundary, SPA re-scan, scrub-don't-detach, shadow-DOM coverage, rule-default centralization + build-time overrides, no-telemetry policy, build-time decoded injection patterns, the Biome+ESLint split, the background-worker purity canary, CSS-first selector hide, and CalVer + workflow-driven releases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found.
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The README header still said "MADR 3.0" after the format switched to 4.0 during authoring. Caught by unblocked[bot] on PR #226. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backfills a
decisions/tree of MADR 4.0 ADRscovering 15 load-bearing decisions reconstructed from merged PRs, issues, and
the user-facing docs.
Each ADR cites its primary source inline (PR description, review thread,
issue body, or doc passage); none of the pros/cons or motivations are
invented. Where one PR superseded another (PR #221 supersedes PR #61's
JSON+codegen pipeline for rule defaults), the supersession is captured in
the relevant ADR's status + Consequences.
Decisions captured
LICENSING.md,LICENSE,.github/CLA.md<target>-<verb>, five verbs)data-abs-*DOM markers inlib/dom-markers.tslib/↔rules/import boundary via ESLintAGENTS.mdrule-metadata.ts+ build-time override flagremoveEntirelyrulesworkflow_dispatch-driven extension releaseConventions
NNNN-kebab-case-title.mdunderdecisions/.status,date). Thedecision-makers/consulted/informedfields are intentionallyomitted — this is a small project with a single primary maintainer.
decisions/README.mdindexes every ADR with a one-line description andstatus.
Test plan
pre-commit run --files decisions/*.md— mdformat + markdownlint clean.invented motivations.
🤖 Generated with Claude Code