Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2441: make highlight brick root aware #2442

Merged
merged 1 commit into from Jan 20, 2022
Merged

#2441: make highlight brick root aware #2442

merged 1 commit into from Jan 20, 2022

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jan 20, 2022 •
edited

Closes #2441

NOTE: this is a backward incompatible change, but it's very unlikely it will impact anyone. If it does, the migration is to just set the brick context as "document" and not "inherit"

@twschiller twschiller enabled auto-merge (squash) January 20, 2022 14:45
@fregante
Copy link
Collaborator

I'm not familiar with how the "root" awareness works, so I can't advise here yet.

@twschiller twschiller merged commit 14f9e7e into main Jan 20, 2022
@twschiller twschiller deleted the feature/2441-highlight-root-aware branch January 20, 2022 18:36
@twschiller twschiller added this to the 1.5.1 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante Awaiting requested review from fregante

@orliesaurus orliesaurus Awaiting requested review from orliesaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

Make highlight brick root-aware
2 participants
@twschiller @fregante