Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem to not use any Rails specific code #15

Closed
wants to merge 1 commit into from
Closed

Update gem to not use any Rails specific code #15

wants to merge 1 commit into from

Conversation

cbetta
Copy link
Contributor

@cbetta cbetta commented Oct 28, 2016

  • Replaced starts_with? with the Ruby native start_with?
  • Replaced present? with != nil
  • Replaced presence with the literal implementation from the Rails codebase

With these changes I've been able to successfully deploy a Sinatra app.

Closes #14

@jalada
Copy link
Collaborator

jalada commented Nov 14, 2016

Thanks for this @cbetta. Sorry I haven't had a chance to review recently, I will try to soon :)

@cbetta
Copy link
Contributor Author

cbetta commented Nov 30, 2016

@jalada how is that review coming?

jalada added a commit that referenced this pull request Dec 10, 2016
@jalada
Copy link
Collaborator

jalada commented Dec 10, 2016

Thanks @cbetta! I made some syntax tweaks but otherwise all good. Your contribution is much appreciated. I made an example app for others using Sinatra to show the steps you need to take, as there are a couple of places you have to add LetsEncrypt.configure and load in the rake tasks. Hope that helps! :)

@jalada jalada closed this Dec 10, 2016
@cbetta
Copy link
Contributor Author

cbetta commented Dec 12, 2016

Thanks @jalada! FYI I already shipped this to Flow2: https://github.com/peterc/flow2/pull/9 which is a Sinatra app :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants